remove ada_constexpr declaration (#758)

Author: anonrig

include/ada/checkers.h

@@ -85,7 +85,7 @@ inline constexpr bool is_normalized_windows_drive_letter(
  * does not contain uppercase ASCII characters (the input should have been
  * lowered cased before calling this function) and is not empty.
  */
-ada_really_inline ada_constexpr bool is_ipv4(std::string_view view) noexcept;
+ada_really_inline constexpr bool is_ipv4(std::string_view view) noexcept;
 
 /**
  * @private

include/ada/common_defs.h

@@ -173,18 +173,6 @@ namespace ada {
 }
 }  // namespace ada
 
-#if defined(__GNUC__) && !defined(__clang__)
-#if __GNUC__ <= 8
-#define ADA_OLD_GCC 1
-#endif  //  __GNUC__ <= 8
-#endif  // defined(__GNUC__) && !defined(__clang__)
-
-#if ADA_OLD_GCC
-#define ada_constexpr
-#else
-#define ada_constexpr constexpr
-#endif
-
 // Unless the programmer has already set ADA_DEVELOPMENT_CHECKS,
 // we want to set it under debug builds. We detect a debug build
 // under Visual Studio when the _DEBUG macro is set. Under the other

include/ada/unicode.h

@@ -147,7 +147,7 @@ ada_really_inline constexpr bool is_ascii_tab_or_newline(char c) noexcept;
  * @details A double-dot path segment must be ".." or an ASCII case-insensitive
  * match for ".%2e", "%2e.", or "%2e%2e".
  */
-ada_really_inline ada_constexpr bool is_double_dot_path_segment(
+ada_really_inline constexpr bool is_double_dot_path_segment(
     std::string_view input) noexcept;
 
 /**

src/checkers.cpp

@@ -4,7 +4,7 @@
 
 namespace ada::checkers {
 
-ada_really_inline ada_constexpr bool is_ipv4(std::string_view view) noexcept {
+ada_really_inline constexpr bool is_ipv4(std::string_view view) noexcept {
   // The string is not empty and does not contain upper case ASCII characters.
   //
   // Optimization. To be considered as a possible ipv4, the string must end

src/unicode.cpp

@@ -284,7 +284,7 @@ ada_really_inline constexpr bool is_ascii_tab_or_newline(
 constexpr std::string_view table_is_double_dot_path_segment[] = {
     "..", "%2e.", ".%2e", "%2e%2e"};
 
-ada_really_inline ada_constexpr bool is_double_dot_path_segment(
+ada_really_inline constexpr bool is_double_dot_path_segment(
     std::string_view input) noexcept {
   // This will catch most cases:
   // The length must be 2,4 or 6.