Install the CodeQL bundle in the toolcache. #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-cheb
reviewed
Sep 8, 2020
al-cheb
reviewed
Sep 8, 2020
al-cheb
reviewed
Sep 8, 2020
al-cheb
reviewed
Sep 8, 2020
al-cheb
reviewed
Sep 8, 2020
chrisgavin
force-pushed
the
install-codeql-bundle
branch
from
185541b to
c72e08b
Compare
chrisgavin
force-pushed
the
install-codeql-bundle
branch
from
0286556 to
60d40e5
Compare
chrisgavin
force-pushed
the
install-codeql-bundle
branch
2 times, most recently
from
267653f to
4ad8e86
Compare
chrisgavin
force-pushed
the
install-codeql-bundle
branch
from
4ad8e86 to
49dc2ce
Compare
Contributor
Author
|
Thank you so much for your feedback @al-cheb and @maxim-lobanov. Apologies for how long it's taken to get this in shape. I think it's now working so whenever you get a chance a re-review would be fantastic! Unfortunately I've not been able to fully test it as the Linux image builds are currently failing to download Cabal and the Windows image builds are failing to download the Edge Driver but I'm hoping everything is now right. |
maxim-lobanov
approved these changes
Sep 21, 2020
2 tasks
Contributor
|
/azp run windows2016, windows2019, ubuntu1604, ubuntu1804, ubuntu2004 |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This installs the CodeQL CLI bundle that is used by the CodeQL Action to the toolcache.
The bundle takes about 90 seconds to download on Linux, closer to double that on Windows and it takes up 1.8GB when unzipped. (I appreciate this is pretty big, but it should save a significant amount of runner minutes for Code Scanning workflows.)
I've unfortunately not managed to get the tooling for building images set up locally so apologies in advance if there are any errors. I've done my best to test the setup scripts manually.
Related issue:
Closes #1544.
Check list