Skip to content

Compile HLS from source #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ on: push
jobs:
docker:
strategy:
fail-fast: false
matrix:
include:
- { ghc: 9.0.2, hls: 1.7.0.0 }
- { ghc: 9.2.4, hls: '' }
- { ghc: 9.4.2, hls: '' }
- { ghc: 9.0.2, hls: 830596ee212d4f2fbbc81bcf5d08574ae96947d3 }
- { ghc: 9.2.4, hls: 830596ee212d4f2fbbc81bcf5d08574ae96947d3 }
- { ghc: 9.4.2, hls: 830596ee212d4f2fbbc81bcf5d08574ae96947d3 }
name: Docker with GHC ${{ matrix.ghc }}
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ ARG HLS_VERSION=1.7.0.0
RUN \
set -o errexit -o xtrace; \
if test -n "$HLS_VERSION"; then \
ghcup install hls "$HLS_VERSION" --set; \
ghcup gc --hls-no-ghc; \
ghcup compile hls --cabal-update --ghc "$GHC_VERSION" --git-ref "$HLS_VERSION"; \
rm --recursive /cabal-store/* ~/.cabal/logs ~/.cabal/packages; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try running haskell-language-server-wrapper from the container this Dockerfile builds?

I recall removing ~/.cabal.packages causing errors along the lines of cannot find libHSbase ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not try that out. And this build failed in CI anyway, so I'm going to close this PR.

Copy link
Contributor

@codygman codygman Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reasons for failure on your or my CI build failure output in #7.

I was able to build it locally, so I'm guessing it's running out of memory or something.

Am I missing something or do you also not see any reasons for failure in either build output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason for the failure either. My guess, like yours, is out of memory. Probably ExitFailure 9.

For what it's worth, it did build for me locally.

haskell-language-server-wrapper --version; \
fi

Expand Down