Remove duplicate rows for CVSS

Signed-off-by: ziadhany <[email protected]>

Author: ziadhany

vulnerabilities/importers/__init__.py

@@ -24,7 +24,7 @@
     github.GitHubAPIImporter,
     nvd.NVDImporter,
     openssl.OpensslImporter,
-    redhat.RedhatImporter,
+    # redhat.RedhatImporter,
     pysec.PyPIImporter,
     debian.DebianImporter,
     gitlab.GitLabAPIImporter,

vulnerabilities/migrations/0028_vulnerabilityseverity_scoring_elements_and_more.py renamed to vulnerabilities/migrations/0028_vulnerabilityseverity_scoring_elements.py

@@ -1,4 +1,4 @@
-# Generated by Django 4.0.7 on 2022-09-12 14:50
+# Generated by Django 4.0.7 on 2022-09-22 21:25
 
 from django.db import migrations, models
 
@@ -15,9 +15,4 @@ class Migration(migrations.Migration):
             name='scoring_elements',
             field=models.CharField(help_text='Supporting a scoring elements as a string For example a CVSS vector Important, High, Medium ,Low.Typically used to compute the value', max_length=100, null=True),
         ),
-        migrations.AlterField(
-            model_name='vulnerabilityseverity',
-            name='value',
-            field=models.CharField(help_text='Score Value expressed as a number such as 9.0 that can be sorted or compared', max_length=50),
-        ),
     ]

vulnerabilities/migrations/0029_vulnerabilityserverity_compute_score.py

@@ -0,0 +1,24 @@
+from django.db import migrations
+
+from vulnerabilities.severity_systems import SCORING_SYSTEMS
+
+
+def compute_score(apps, schema_editor):
+    Vuln_severity = apps.get_model('vulnerabilities', 'VulnerabilitySeverity')
+    for vuln_severity in Vuln_severity.objects.all():
+        if vuln_severity.value and not vuln_severity.scoring_elements:
+            try:
+                vuln_severity.scoring_elements = SCORING_SYSTEMS[vuln_severity.scoring_system].as_score(vuln_severity.value)
+                vuln_severity.save()
+            except NotImplementedError:
+                pass
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('vulnerabilities', '0028_vulnerabilityseverity_scoring_elements'),
+    ]
+
+    operations = [
+        migrations.RunPython(compute_score),
+    ]

vulnerabilities/migrations/0030_vulnerabilityseverity _rm_extra_records_swap.py

@@ -0,0 +1,51 @@
+from django.db import migrations
+
+
+def remove_extra_rows(apps, schema_editor):
+    Vuln_severity = apps.get_model('vulnerabilities', 'VulnerabilitySeverity')
+    for vuln_severity in Vuln_severity.objects.all():
+        duplicated_row = None
+        if vuln_severity.scoring_system == "cvssv2_vector":
+            duplicated_row = Vuln_severity.objects.filter(reference_id=vuln_severity.reference_id,
+                                                          scoring_system="cvssv2",
+                                                          value=vuln_severity.scoring_elements)
+
+        elif vuln_severity.scoring_system == "cvssv3_vector":
+            duplicated_row = Vuln_severity.objects.filter(reference_id=vuln_severity.reference_id,
+                                                          scoring_system="cvssv3",
+                                                          value=vuln_severity.scoring_elements)
+
+        elif vuln_severity.scoring_system == "cvssv3.1_vector":
+            duplicated_row = Vuln_severity.objects.filter(reference_id=vuln_severity.reference_id,
+                                                          scoring_system="cvssv3.1",
+                                                          value=vuln_severity.scoring_elements)
+
+        if duplicated_row and duplicated_row.count() == 1:
+            duplicated_row[0].delete()
+
+
+def swap_scoring_elements_with_value(apps, schema_editor):
+    Vuln_severity = apps.get_model('vulnerabilities', 'VulnerabilitySeverity')
+    for vuln_severity in Vuln_severity.objects.all():
+        mapper_scoring_system = {
+            "cvssv2_vector": "cvssv2",
+            "cvssv3_vector": "cvssv3",
+            "cvssv3.1_vector": "cvssv3.1",
+        }
+        if vuln_severity.scoring_system in ["cvssv2_vector", "cvssv3_vector", "cvssv3.1_vector"]:
+            vuln_severity.scoring_system = mapper_scoring_system[vuln_severity.scoring_system]
+            temp = vuln_severity.scoring_elements  # value
+            vuln_severity.scoring_elements = vuln_severity.value
+            vuln_severity.value = temp
+            vuln_severity.save()
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('vulnerabilities', '0029_vulnerabilityserverity_compute_score'),
+    ]
+
+    operations = [
+        migrations.RunPython(remove_extra_rows),
+        migrations.RunPython(swap_scoring_elements_with_value),
+    ]

vulnerabilities/models.py

@@ -367,10 +367,12 @@ class VulnerabilitySeverity(models.Model):
         ),
     )
 
-    value = models.CharField(
-        max_length=50,
-        help_text="Score Value expressed as a number such as 9.0 that can be sorted or compared",
-    )
+    # value = models.CharField(
+    #     max_length=50,
+    #     help_text="Score Value expressed as a number such as 9.0 that can be sorted or compared",
+    # )
+
+    value = models.CharField(max_length=50, help_text="Example: 9.0, Important, High")
 
     scoring_elements = models.CharField(
         max_length=100,
@@ -380,15 +382,6 @@ class VulnerabilitySeverity(models.Model):
         "Typically used to compute the value",
     )
 
-    def save(self, *args, **kwargs):
-        super().save(*args, **kwargs)
-        if not self.value and self.scoring_elements:
-            try:
-                self.value = SCORING_SYSTEMS[self.scoring_system].as_score(self.value)
-                super().save(update_fields=["value"])
-            except NotImplementedError:
-                pass
-
     class Meta:
         unique_together = ["reference", "scoring_system", "value"]
         ordering = ["reference", "scoring_system", "value"]

vulnerabilities/severity_systems.py

@@ -52,7 +52,7 @@ def as_score(self, value) -> Decimal:
             c = CVSS3(value)
             return c.base_score
         else:
-            raise NotImplementedError
+            raise NotImplementedError("Can't compute a score")
 
 
 CVSSV2 = ScoringSystem(