Skip to content

Low level chat: Added iterative search to prevent instructions from being echoed #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

Low level chat: Added iterative search to prevent instructions from being echoed #63

merged 1 commit into from
Apr 10, 2023

Conversation

SagsMug
Copy link
Contributor

@SagsMug SagsMug commented Apr 10, 2023

Implements

  • Use mmap option and argument
  • Verbose prompt argument
  • IterSearch which prevents the instruction prefix from being echoed
  • Ignore EOS option
  • Fixes a bug that causes exactly 1 character to be printed before the instruction break kicks in

Ignore EOS option hopefully fixes #59

Added iterative search to prevent instructions from being echoed, add…
0cccb41 
… ignore eos, add no-mmap, fixed 1 character echo too much bug
@abetlen
Copy link
Owner

abetlen commented Apr 10, 2023

Looks good to me, thank you!

@abetlen abetlen merged commit 63d8a3c into abetlen:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chat does not remember initial prompt as well as llama.cpp
2 participants
@SagsMug @abetlen