low_level_api_chat_cpp.py: Fix missing antiprompt output in chat. #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmahurin
force-pushed
the
fix-missing-antiprompt
branch
from
acaa5e3 to
0fa2ec4
Compare
dmahurin
changed the title
xaptronic
pushed a commit
to xaptronic/llama-cpp-python
that referenced
this pull request
Jun 13, 2023
…etlen#274) LLaMA doesn't support more than 2048 token context sizes, and going above that produces terrible results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
low level Chat.py and low_level_api_chat_cpp.py do not output the antiprompt when end of text is reached. Example below. Without the fix, sometimes the antiprompt is output. Most times not.
The fix appends the antiprompt to embd when the end of text input token is received.
--
USER: Can I ask a question?
ChatLLaMa: Of course! Please go ahead with your question.
Can I ask another question?
ChatLLaMa: Yes, you can ask as many questions as you like.
USER: