Skip to content

Update README.md to reflect changes for passing the model for the docker image #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

th-neu
Copy link
Contributor

@th-neu th-neu commented May 12, 2023

Since its now --model the old way of -emodel does not work anymore.

@abetlen
Copy link
Owner

abetlen commented May 12, 2023

@th-neu the environment variables should still work as a fallback to cli options, there was a bug with this but should've been fixed in #171

@th-neu
Copy link
Contributor Author

th-neu commented May 12, 2023

The entrypoint is not an array. As such passing anything will not work afaik. I am on that

@abetlen
Copy link
Owner

abetlen commented May 12, 2023

Ah gotcha, thanks!

Just to confirm though, does the -e MODEL approach work for you?

@th-neu
Copy link
Contributor Author

th-neu commented May 12, 2023

Ah gotcha, thanks!

Just to confirm though, does the -e MODEL approach work for you?

No. Always getting "none is not an allowed value (type=type_error.none.not_allowed)" as in the model is not found.
Docker version 23.0.6, build ef23cbc

@abetlen
Copy link
Owner

abetlen commented May 12, 2023

I think that's an older version can you try running docker images then docker rmi by the image you have by id and pull it again.

I'll try to update the docker publish action to use the release tags.

@th-neu
Copy link
Contributor Author

th-neu commented May 12, 2023

I think that's an older version can you try running docker images then docker rmi by the image you have by id and pull it again.

I'll try to update the docker publish action to use the release tags.

I am building my own docker images. And trying yours. So those are up to date. Does it work for you? A typo for me would not be uncommen. Building the images is not the problem. Running is.

@th-neu
Copy link
Contributor Author

th-neu commented May 12, 2023

#191 this should fix the passing of the Model. This README.md update would then not matter anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants