Skip to content

Add self extend support #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add self extend support #1090

wants to merge 6 commits into from

Conversation

Josh-XT
Copy link
Contributor

@Josh-XT Josh-XT commented Jan 16, 2024

Add self extend support

@Josh-XT Josh-XT marked this pull request as draft January 16, 2024 01:45
@Josh-XT Josh-XT marked this pull request as ready for review January 16, 2024 01:54
@Josh-XT
Copy link
Contributor Author

Josh-XT commented Jan 17, 2024

Haven't had time to finish the rest of this, got pulled away in the middle! Sorry - I'll reopen when ready if someone doesn't beat me to the implementation.

@Josh-XT Josh-XT closed this Jan 17, 2024
@jshph
Copy link

jshph commented Jan 17, 2024

Hey @Josh-XT thanks for taking a stab. Curious if the implementation is in the right direction here, I was poking at it yesterday and saw the Params struct being modified. I wonder if that'd affect the parsing of args downstream.

@Josh-XT
Copy link
Contributor Author

Josh-XT commented Jan 17, 2024

Hey @Josh-XT thanks for taking a stab. Curious if the implementation is in the right direction here, I was poking at it yesterday and saw the Params struct being modified. I wonder if that'd affect the parsing of args downstream.

I was attempting to follow the changes made on the cpp repo but while hanging out with my 4 year old, then he made a mess and I had to stop. 🤣 I was trying to do the cpp server example at the same time when my plans were changed. The implementation is pretty straightforward. I think the grp-attn-n and grp-attn-w could (and probably will) be automated away.

@ExtReMLapin
Copy link
Contributor

Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants