Skip to content

Docker examples are broke. Are they for dev or prod? #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gjmulder opened this issue May 30, 2023 · 1 comment
Closed

Docker examples are broke. Are they for dev or prod? #298

gjmulder opened this issue May 30, 2023 · 1 comment
Labels

Comments

@gjmulder
Copy link
Contributor

By reorganising the Dockerfiles I broke the install for the simple Dockerfiles, as they copy the repo from the current dir into the image, but they're now located in a subdir. Docker builds can't copy files from a parent directory AFAIK.

Do we want to either:

pip install the latest llama-cpp-python package in this Dockerfiles so that they are the most minimal install

or:

Install the latest commit of llama-cpp-python?

If the second option is chosen then a better way is to git clone https://github.com/abetlen/llama-cpp-python.git as part of the docker build, as then there's no dependency on where the Dockerfile is located.

@gjmulder gjmulder added the build label May 30, 2023
@gjmulder
Copy link
Contributor Author

gjmulder commented Jun 2, 2023

Proposed solution in #310

@gjmulder gjmulder closed this as completed Jun 5, 2023
xaptronic pushed a commit to xaptronic/llama-cpp-python that referenced this issue Jun 13, 2023
Co-authored-by: Johnman <johnman@github>
Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant