Cleanup old sources between compilations #273
Conversation
This is required since KSP accepts a list of source directories while Kotlin accepts a list of source files. This means that if you compile multiple times, removing a source file between, KSP will still process the removed files.
| @@ -9,7 +9,7 @@ import org.intellij.lang.annotations.Language | |||
| * A source file for the [KotlinCompilation] | |||
| */ | |||
| abstract class SourceFile { | |||
| internal abstract fun writeIfNeeded(dir: File): File | |||
| internal abstract fun writeTo(dir: File): File | |||
There was a problem hiding this comment.
I figured that renaming this makes sense since it will always write the contents now. Can revert though.
| @@ -50,12 +50,13 @@ abstract class SourceFile { | |||
| /** | |||
| * Compile an existing source file | |||
| */ | |||
| @Deprecated("This will not work reliably with KSP, use `new` instead") | |||
There was a problem hiding this comment.
Since KSP2 accepts source directories KCT can't allow arbitrary files now.
| @@ -117,6 +117,12 @@ var KotlinCompilation.kspLoggingLevels: Set<CompilerMessageSeverity> | |||
| tool.loggingLevels = value | |||
| } | |||
|
|
|||
| @ExperimentalCompilerApi | |||
| val JvmCompilationResult.sourcesGeneratedBySymbolProcessor: Sequence<File> | |||
| get() = outputDirectory.parentFile.resolve("ksp/sources") | |||
There was a problem hiding this comment.
I'm not thrilled about this solution but other solutions require exposing the compilation which doesn't seem ideal.
There was a problem hiding this comment.
Does the round matter here? KSP does output files by round in some circumstances
There was a problem hiding this comment.
Once you have a result all rounds should be over, so this should include all files. But perhaps I misunderstand your question?
| @@ -117,6 +117,12 @@ var KotlinCompilation.kspLoggingLevels: Set<CompilerMessageSeverity> | |||
| tool.loggingLevels = value | |||
| } | |||
|
|
|||
| @ExperimentalCompilerApi | |||
| val JvmCompilationResult.sourcesGeneratedBySymbolProcessor: Sequence<File> | |||
| get() = outputDirectory.parentFile.resolve("ksp/sources") | |||
There was a problem hiding this comment.
Does the round matter here? KSP does output files by round in some circumstances
This is required since KSP accepts a list of source directories while Kotlin accepts a list of source files. This means that if you compile multiple times, removing a source file between, KSP will still process the removed files.