Skip to content

Commit 3df6360

Browse files
XuehaiPanpytorchmergebot
authored andcommitted
[BE][Easy][setup] use super().method(...) in command subclasses in setup.py (pytorch#156044)
Pull Request resolved: pytorch#156044 Approved by: https://github.com/albanD ghstack dependencies: pytorch#156741
1 parent d0a9629 commit 3df6360

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

setup.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@
267267
from typing import Any, ClassVar, IO
268268

269269
import setuptools.command.build_ext
270-
import setuptools.command.install
271270
import setuptools.command.sdist
272271
import setuptools.errors
273272
from setuptools import Command, Extension, find_packages, setup
@@ -767,8 +766,7 @@ def run(self) -> None:
767766
):
768767
os.environ["CC"] = str(os.environ["CC"])
769768

770-
# It's an old-style class in Python 2.7...
771-
setuptools.command.build_ext.build_ext.run(self)
769+
super().run()
772770

773771
if IS_DARWIN:
774772
self._embed_libomp()
@@ -835,10 +833,10 @@ def build_extensions(self) -> None:
835833
os.makedirs(dst_dir)
836834
self.copy_file(src, dst)
837835

838-
setuptools.command.build_ext.build_ext.build_extensions(self)
836+
super().build_extensions()
839837

840838
def get_outputs(self) -> list[str]:
841-
outputs = setuptools.command.build_ext.build_ext.get_outputs(self)
839+
outputs = super().get_outputs()
842840
outputs.append(os.path.join(self.build_lib, "caffe2"))
843841
report(f"setup.py::get_outputs returning {outputs}")
844842
return outputs
@@ -942,11 +940,6 @@ def write_wheelfile(self, *args: Any, **kwargs: Any) -> None:
942940
open(os.path.join(self.bdist_dir, "torch", "__init__.py"), "w").close()
943941

944942

945-
class install(setuptools.command.install.install):
946-
def run(self) -> None:
947-
super().run()
948-
949-
950943
class clean(Command):
951944
user_options: ClassVar[list[tuple[str, str | None, str]]] = []
952945

@@ -1144,7 +1137,6 @@ def make_relative_rpath_args(path: str) -> list[str]:
11441137
cmdclass = {
11451138
"build_ext": build_ext,
11461139
"clean": clean,
1147-
"install": install,
11481140
"sdist": sdist,
11491141
}
11501142
if wheel_concatenate is not None:

0 commit comments

Comments
 (0)