Skip to content

Remove line breaks from docblocks #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2014
Merged

Conversation

JDGrimes
Copy link
Contributor

This simply replaces them with spaces.

Should fix #114

@Rarst
Copy link
Contributor

Rarst commented Aug 24, 2014

  1. Needs cross–platform regex or it will explode into someone's face sooner or later (likely mine). I think we went with replacing [\r\n]+ last time, fixing up issue in wp-cli.
  2. Just to be sure, this is after Markdown, so it won't mess with creating paragraphs properly, correct?

@JDGrimes
Copy link
Contributor Author

  1. Forgot about that, I'll add it later today.
  2. Yes, the p tags are already present. But there are still line breaks there that get converted to br's on import.

@JDGrimes
Copy link
Contributor Author

Updated (and with unit tests), although 2639953 should be discarded (I'm not really a git guru :-). Maybe you should just cherry-pick the other 3 commits?

Rarst added a commit that referenced this pull request Aug 26, 2014
Remove line breaks from docblocks
@Rarst Rarst merged commit 155df34 into WordPress:master Aug 26, 2014
@Rarst
Copy link
Contributor

Rarst commented Aug 26, 2014

Maybe you should just cherry-pick the other 3 commits?

Haha, you are so funny... YOLO merge!

@JDGrimes JDGrimes deleted the issue-114 branch August 26, 2014 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaks in inline docs shouldn't be parsed
2 participants