Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Added Exception Handling entry to document/core/appendix/changes.rst #267

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

ioannad
Copy link
Collaborator

@ioannad ioannad commented Mar 6, 2023

Please note:

Apart from try-catch and try-delegate, all other instructions in changes.rst are given without the immediates or any arguments that follow them. Since try-catch and try-delegate are the only new structured block instructions I guessed it is ok to include the full form of these new instructions here.

…st`.

Please note:

Apart from try-catch and try-delegate, all other instructions in `changes.rst`
are given without the immediates or any arguments that follow them.
Since try-catch and try-delegate are the only new structured block instructions
I guessed it is ok to include the full form of these new instructions here.
@ioannad ioannad requested review from aheejin and rossberg March 6, 2023 14:48
Fixes the build fail caused by the typo `\bt` (should have been `\blocktype`.
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


Added tag type, instructions that throw exceptions of a tag type, and instructions that handle exceptions. [#proposal-eh]_

* New :ref:`tag type <syntax-tagtype>`: :math:`[t^\ast]\to[]`-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd replace this with tag definitions, imports, and exports. Tag types are more of an auxiliary notion to support these constructs.


* New :ref:`tag type <syntax-tagtype>`: :math:`[t^\ast]\to[]`-

* New :ref:`tag section <binary-tagsec>` in binary format.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move this to the end of the list.


* New handler :ref:`control instructions <syntax-instr-control>`: :math:`\TRY~\X{bt}~\instr_1^\ast~(\CATCH~x~\instr_2^\ast)^\ast~(\CATCHALL~\instr_3^\ast)^?\END`, :math:`\TRY~\X{bt}~\instr^\ast~\DELEGATE~l`.

* New uncaught exception :ref:`result <syntax-result>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this, it's more like an implication, not a feature.

@ioannad ioannad requested a review from rossberg March 17, 2023 16:34
@ioannad ioannad merged commit 5785828 into WebAssembly:main Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants