Let GenerateDynCalls generate dynCalls for invokes #3192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves dynCall generating functionaity for invokes from `EmscriptenGlueGenerator` to `GenerateDynCalls` pass. So now `GenerateDynCalls` pass will take care of all cases we need dynCalls: functions in tables and invokes.
aheejin
commented
Oct 1, 2020
| (local.get $1) | ||
| (local.get $fptr) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
These dynCalls are generated because the input file contains invoke_ functions. Before they were not targets for dynCall generations because EmscriptenGlueGenerator looked for the format generated by the LLVM backend, like __invoke_void_i32, and not invoke_vi. But now this pass is supposed to run after renaming invokes, this pass should look for invoke_ instead, resulting in this change.
aheejin
added a commit
that referenced
this pull request
Oct 11, 2020
Now that we are renaming invoke wrappers and `emscripten_longjmp_jmpbuf` in the wasm backend, this deletes all related renaming routines and relevant tests. Depends on #3192. Addresses: #3043 and #3081 Companions: https://reviews.llvm.org/D88697 emscripten-core/emscripten#12399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves dynCall generating functionaity for invokes from
EmscriptenGlueGeneratortoGenerateDynCallspass. So nowGenerateDynCallspass will take care of all cases we need dynCalls:functions in tables and invokes.