wasm-emscripten-finalize: Add flags to limit dynCall creation #3070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
kripken
reviewed
Aug 21, 2020
There was a problem hiding this comment.
I assume the overall plan here is to move to always do either no dynCalls or just i64 ones? (and the old way of doing things is supported for now until we move to that?
"limited" might just be "i64" perhaps. That is, "generateI64DynCalls" etc. Could be clearer?
Two flags here, one to completely remove dynCalls, and another to limit them to only signatures that contains i64. See #3043
kripken
approved these changes
Aug 26, 2020
src/wasm/wasm-emscripten.cpp
Outdated
| @@ -143,7 +143,27 @@ inline void exportFunction(Module& wasm, Name name, bool must_export) { | |||
| wasm.addExport(exp); | |||
| } | |||
|
|
|||
| static bool needsDynCall(Signature sig) { | |||
There was a problem hiding this comment.
how about hasI64? This function by itself doesn't decide if we need a dyncall or not (we may have passed a flag that says we never need any), it just identifies an i64 specifically IIUC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two flags here, one to completely remove dynCalls, and another to
limit them to only signatures that contains i64.
See #3043