Solve Bugs

Author: AustinShalit

.travis.yml

@@ -30,7 +30,7 @@ install:
   - '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && ./gradlew :ui:jfxNative --stacktrace || ./gradlew --stacktrace '
 
 script:
-  - ./gradlew checkstyleMain checkstyleTest pmdMain findbugsMain findbugsTest jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
+  - ./gradlew checkstyleMain checkstyleTest pmdMain findbugsMain jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
 
 after_success:
   - if [[ "$TRAVIS_OS_NAME" != "osx" ]]; then codecov         ; fi

appveyor.yml

@@ -6,7 +6,7 @@ build_script:
 
 # to run your custom scripts instead of automatic tests
 test_script:
-  - gradlew.bat checkstyleMain checkstyleTest pmdMain findbugsMain findbugsTest jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
+  - gradlew.bat checkstyleMain checkstyleTest pmdMain findbugsMain jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
 
 platform:
   - x64

build.gradle

@@ -155,6 +155,7 @@ configure(allprojects - project(':ui:linuxLauncher')) {
 
 
     dependencies {
+        compile group: 'com.google.code.findbugs', name: 'annotations', version: '3.0.1'
         testCompile group: 'net.jodah', name: 'concurrentunit', version: '0.4.2'
         testCompile group: 'org.hamcrest', name: 'hamcrest-all', version: '1.3'
         testCompile group: 'junit', name: 'junit', version: '4.12'

core/src/main/java/edu/wpi/grip/core/operations/composite/PublishVideoOperation.java

@@ -9,6 +9,8 @@
 
 import com.google.common.collect.ImmutableList;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import org.bytedeco.javacpp.BytePointer;
 import org.bytedeco.javacpp.IntPointer;
 
@@ -133,6 +135,7 @@ public class PublishVideoOperation implements Operation {
   };
 
   @SuppressWarnings("JavadocMethod")
+  @SuppressFBWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
   public PublishVideoOperation(InputSocket.Factory inputSocketFactory) {
     if (numSteps != 0) {
       throw new IllegalStateException("Only one instance of PublishVideoOperation may exist");

core/src/main/java/edu/wpi/grip/core/operations/network/http/DataHandler.java

@@ -12,6 +12,8 @@
 import com.google.inject.Inject;
 import com.google.inject.Singleton;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import org.eclipse.jetty.server.Request;
 
 import java.io.IOException;
@@ -69,6 +71,7 @@ public final class DataHandler extends PedanticHandler {
   }
 
   @Override
+  @SuppressFBWarnings("UW_UNCOND_WAIT")
   protected void handleIfPassed(String target,
                                 Request baseRequest,
                                 HttpServletRequest request,

core/src/main/java/edu/wpi/grip/core/util/SafeShutdown.java

@@ -1,5 +1,7 @@
 package edu.wpi.grip.core.util;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import javax.annotation.Nullable;
 
 /**
@@ -16,8 +18,10 @@ public final class SafeShutdown {
      * flagging a shutdown
      * that we can't control.
      */
+
     Runtime.getRuntime().addShutdownHook(new Thread() {
       @Override
+      @SuppressFBWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
       public void run() {
         SafeShutdown.stopping = true;
       }

findBugsSuppressions.xml

@@ -5,4 +5,7 @@
     <Match>
         <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
     </Match>
+    <Match>
+        <Bug pattern="NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION" />
+    </Match>
 </FindBugsFilter>

ui/src/main/java/edu/wpi/grip/ui/preview/BlobsSocketPreviewView.java

@@ -8,6 +8,8 @@
 
 import com.google.common.eventbus.Subscribe;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import javafx.application.Platform;
 import javafx.geometry.Orientation;
 import javafx.scene.control.CheckBox;
@@ -38,7 +40,8 @@ public class BlobsSocketPreviewView extends SocketPreviewView<BlobsReport> {
   private final Mat tmp = new Mat();
   private final GripPlatform platform;
   @SuppressWarnings("PMD.ImmutableField")
-  private boolean showInputImage;
+  @SuppressFBWarnings("IS2_INCONSISTENT_SYNC")
+  private boolean showInputImage = false;
 
   /**
    * @param socket An output socket to preview.

ui/src/main/java/edu/wpi/grip/ui/preview/LinesSocketPreviewView.java

@@ -8,6 +8,8 @@
 
 import com.google.common.eventbus.Subscribe;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import java.util.List;
 import javafx.application.Platform;
 import javafx.geometry.Orientation;
@@ -40,7 +42,8 @@ public class LinesSocketPreviewView extends SocketPreviewView<LinesReport> {
   private final Mat tmp = new Mat();
   private final GripPlatform platform;
   @SuppressWarnings("PMD.ImmutableField")
-  private boolean showInputImage;
+  @SuppressFBWarnings("IS2_INCONSISTENT_SYNC")
+  private boolean showInputImage = false;
 
   /**
    * @param socket An output socket to preview.