Fixing trunk CI issues #1638
Merged
Fixing trunk CI issues #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gegenerate API file based on 1.0.0 via "dmytro/regenerate-scraped-file" branch.
jimon
force-pushed
the
dmytro/fix-trunk-builds
branch
from
187d1d2 to
6ae62ca
Compare
| @@ -17,7 +17,7 @@ namespace Unity.XR.GoogleVr | |||
| [UnityEngine.InputSystem.Layouts.InputControl] [UnityEngine.Scripting.Preserve] public UnityEngine.InputSystem.Controls.ButtonControl volumeDown { get; } | |||
| [UnityEngine.InputSystem.Layouts.InputControl] [UnityEngine.Scripting.Preserve] public UnityEngine.InputSystem.Controls.ButtonControl volumeUp { get; } | |||
| public DaydreamController() {} | |||
| protected virtual void FinishSetup(); | |||
There was a problem hiding this comment.
Seems the pattern here is to change from virtual to override. Is it just the way it is for the new format of "com.unity.coding": "0.1.0-preview.24" or is there any other reason behind it? Anyway, this file was regenerated to meet the new format, correct?
There was a problem hiding this comment.
It was .24 change, it's probably just to mark an overload with override instead of virtual
added 8 commits
February 10, 2023 17:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So com.unity.coding
0.1.0-preview.20that we use no longer compiles on 2023.x.Changes made
I've updated it to
0.1.0-preview.24, but in meanwhile the underlying scraping tool was also updated, so now the output of the tool no longer matched 1.0.0 reference API files we used for validation.I've made a branch
dmytro/regenerate-scraped-fileon top of 1.0.0 tag to regenerate the .api files and updated them in this PR.The rest of the changes is fixing exclusion lists because of all namespace changes.
Notes
Good luck reviewing it! 🔥
PS. I did my best to sanity check outputs, but .api file change is nearly impossible to review without some awk magic.