-
Notifications
You must be signed in to change notification settings - Fork 10
make cbar labelloc possible for all direction #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
fig, ax = uplt.subplots() | ||
h = ax.imshow(data) | ||
locs = "top bottom left right".split() | ||
for loc, labelloc in zip(locs, locs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want all combinations here, not just a zip?
Technically it's possible for all settings (which makes it congruent with
the docs). Need to add some tests to satisfy codecov. Also may refactor the
logic as it is a bit verbose and error prone.
… |
But after Easter🐰 |
Working on a refactor of the Colorbar class. This may take a little while. This way our future testing will be a lot easier as the current functions Would rather do the refactor first than adding the feature without the refactor. |
If a refactor with more testing is coming later, I am OK to merge this PR now. |
ok merging then will put the PR up as a reminder. |
Addresses #163