Skip to content

make cbar labelloc possible for all direction #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

make cbar labelloc possible for all direction #165

merged 4 commits into from
Apr 22, 2025

Conversation

cvanelteren
Copy link
Contributor

@cvanelteren cvanelteren commented Apr 18, 2025 •
edited
Loading

Addresses #163

@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/axes/base.py 40.00% 10 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

beckermr
beckermr reviewed Apr 18, 2025
View reviewed changes
ultraplot/tests/test_colorbar.py
fig, ax = uplt.subplots()
h = ax.imshow(data)
locs = "top bottom left right".split()
for loc, labelloc in zip(locs, locs):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want all combinations here, not just a zip?

@cvanelteren
Copy link
Contributor Author

cvanelteren commented Apr 18, 2025 via email •
edited
Loading

@cvanelteren
Copy link
Contributor Author

But after Easter🐰

@cvanelteren
Copy link
Contributor Author

cvanelteren commented Apr 22, 2025 •
edited
Loading

Working on a refactor of the Colorbar class. This may take a little while. This way our future testing will be a lot easier as the current functions Axes.colorbar and Figure.colorbar are very opague and needs addressing. PR at this point could be merged as testing the properties for the patch would be a bit uggly.

Would rather do the refactor first than adding the feature without the refactor.

@beckermr
Copy link
Collaborator

If a refactor with more testing is coming later, I am OK to merge this PR now.

@cvanelteren
Copy link
Contributor Author

cvanelteren commented Apr 22, 2025 •
edited
Loading

ok merging then will put the PR up as a reminder.

@cvanelteren cvanelteren merged commit 3874817 into Ultraplot:main Apr 22, 2025
14 of 15 checks passed
@cvanelteren cvanelteren deleted the colorbar-loc-fix branch April 22, 2025 10:32
@cvanelteren cvanelteren mentioned this pull request Apr 22, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvanelteren @beckermr