Skip to content

pin @types versions #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Conversation

harunurhan
Copy link
Contributor

  • Fixes errors caused by higher version of @types/handlebars due to
    npm's auto update

Reference: #384 (comment)

@aciccarello
Copy link
Collaborator

Thanks for the PR! I think we should pin all the @types dependencies since they don't conform to semver.

@harunurhan
Copy link
Contributor Author

@aciccarello I agree I could also do in this PR if it's asked, I just pinned the one that I have problem with. I would appreciate if this is merged soon!

@aciccarello
Copy link
Collaborator

@harunurhan I was hoping we'd pin all the types. Would you mind updating that?

@harunurhan harunurhan force-pushed the pin-handlebars-types branch 3 times, most recently from abae7b0 to caa9f03 Compare September 22, 2017 08:16
* Fixes errors caused by typing definition packages that don't respect semantic versioning.
@harunurhan
Copy link
Contributor Author

@aciccarello done, FYI, I had to pin @types/lodash a bit higher due to an error with the current one.

@TypeStrong TypeStrong deleted a comment from harunurhan Sep 22, 2017
@blakeembrey blakeembrey merged commit 80c920c into TypeStrong:master Sep 22, 2017
@aciccarello aciccarello changed the title pin @types/handlebars version pin @types versions Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants