Make @types packages dev dependencies. #434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not install them in users' projects.
|
@hdeshev thanks for the contribution but I don't believe this is the fix that is required. As commented in the issue you linked
We already have about half a dozen issues/PRs related to this issue which you can view for reference. |
This was referenced Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a typing clash with @types/lodash and TypeScript 2.2.1 today.
While that is definitely a problem in the lodash typings, I realized that I wasn't supposed to even have
@types/lodashin my project modules. I found outtypedocinstalls those, which is completely unnecessary.This PR moves all
@typespackages todevDependencies. Probably related to #432.