[#356] Add support for TypeScript 2.1.4 #365
Conversation
…56-update-ts-214
| @@ -7,139 +7,14 @@ | |||
| "preserveConstEnums": true, | |||
| "declaration": true, | |||
| "sourceMap": true, | |||
| "inlineSources": true, | |||
There was a problem hiding this comment.
Please don't remove this. I've explained it a few times now, this is needed for debugging when you install from NPM.
There was a problem hiding this comment.
Ah yes, sorry, I can do that.
| "include": [ | ||
| "src/**/*.ts" | ||
| ], | ||
| "exclude": [ |
There was a problem hiding this comment.
Can you remove the empty exclude?
There was a problem hiding this comment.
Exclude has to be present for TS to compile it correctly, because the default exclude is the current working directory.
error TS18003: No inputs were found in config file 'E:/Development/Contrib/typedoc/tsconfig.json'. Specified 'include' paths were '["src/**/*.ts"]' and 'exclude' paths were '["./"]'.
There was a problem hiding this comment.
That sounds like a bug for someone else then, that's not a normal compiler issue but something must be mutating our config incorrectly.
There was a problem hiding this comment.
Looks like it's been reported TypeStrong/grunt-ts#381.
There was a problem hiding this comment.
What would your preference be? Should I leave it in? It doesn't seem to break anything. I have already enabled passThrough in the gruntfile.
| @@ -0,0 +1,23 @@ | |||
| { | |||
There was a problem hiding this comment.
Please don't check the .vscode files into this project.
There was a problem hiding this comment.
They are helpful for contributors, otherwise contributors have to manually figure out how to set up the debugger (this can be especially difficult for TS-based projects to know what the correct parameters are). It would be preferable to leave them in, there's nothing specific to my workspace that's in the files.
There was a problem hiding this comment.
The thing specific to your workspace is VS code. Should we check in configurations for other IDEs too?
There was a problem hiding this comment.
I like to optimize my projects for a specific xplat IDE, which is VS Code for me--it provides a happy path for contributors. However, you are the maintainer so would you be OK adding the configuration to the CONTRIBUTING readme? That provides a copy/paste way for contributors who want to use VS Code at least.
|
This PR is good, but it would be easier broken into separate PRs for the breaking functionality. I'll merge once those changes are fixed, thanks @kamranayub for your help! |
|
This is what constants look like in 2.1:
It's acceptable for now I think until proper Constant support is added. |
|
@blakeembrey when you have time (no rush) I had responded to your feedback 👍 |
|
Hi - I updated grunt-ts to support |
This PR adds support for TS 2.1.4. Replaces #356
TODO
Notable Changes
Right now, TypeDoc will output an "unknown" type for constant declarations because they are no longer marked as Intrinsic types, instead they are Literal types. I think to properly support constants, there might need to be a new
ReflectionKind.Constantso that constants can be grouped separately from variables.