Fix coverage reporting when tests fail; also push to codecov (#1047)

* Try pushing to codecov; maybe that'll work better

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

Author: cspotcode

.github/workflows/continuous-integration.yml

@@ -33,38 +33,54 @@ jobs:
 
   test:
     needs: lint-build
-    name: "Test #${{ matrix.flavor }}: ${{ matrix.os }}, node v${{ matrix.node }}, ${{ matrix.typescript }}"
-    runs-on: ${{ matrix.os }}
+    name: "Test: ${{ matrix.os }}, node ${{ matrix.node }}, TS ${{ matrix.typescript }}"
+    runs-on: ${{ matrix.os }}-latest
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        os: [ubuntu, windows]
         flavor: [1, 2, 3, 4, 5, 6, 7, 8]
         include:
           - flavor: 1
             node: 10
-            typescript: typescript@latest
+            nodeFlag: 10
+            typescript: latest
+            typescriptFlag: latest
           - flavor: 2
             node: 12
-            typescript: typescript@latest
+            nodeFlag: 12
+            typescript: latest
+            typescriptFlag: latest
           - flavor: 3
             node: 13
-            typescript: typescript@latest
+            nodeFlag: 13
+            typescript: latest
+            typescriptFlag: latest
           - flavor: 4
             node: 13
-            typescript: [email protected]
+            nodeFlag: 13
+            typescript: 2.7
+            typescriptFlag: 2_7
           - flavor: 5
             node: 13
-            typescript: typescript@next
+            nodeFlag: 13
+            typescript: next
+            typescriptFlag: next
           - flavor: 6
             node: 14
-            typescript: typescript@latest
+            nodeFlag: 14
+            typescript: latest
+            typescriptFlag: latest
           - flavor: 7
             node: 14
-            typescript: [email protected]
+            nodeFlag: 14
+            typescript: 2.7
+            typescriptFlag: 2_7
           - flavor: 8
             node: 14
-            typescript: typescript@next
+            nodeFlag: 14
+            typescript: next
+            typescriptFlag: next
     steps:
       # checkout code
       - uses: actions/checkout@v2
@@ -81,14 +97,22 @@ jobs:
         with:
           name: ts-node-packed.tgz
           path: tests/
-      - run: npm install ${{ matrix.typescript }} --force
+      - run: npm install typescript@${{ matrix.typescript }} --force
       - run: npm run test-cov
+      - run: npm run coverage-report
+        if: ${{ always() }}
+      - name: Codecov
+        if: ${{ always() }}
+        uses: codecov/codecov-action@v1
+        with:
+          flags: ${{ matrix.os }},node_${{ matrix.nodeFlag }},typescript_${{ matrix.typescriptFlag }}
+      - run: npm run coverage-fix-paths
+      - run: npm run coverage-report
       - name: Coveralls
         if: ${{ always() }}
         uses: coverallsapp/github-action@master
         with:
           github-token: ${{ secrets.github_token }}
-          flag-name: run-${{ matrix.os }}-${{ matrix.flavor }}
           parallel: true
   finish:
     needs: test

codecov.yml

@@ -0,0 +1,4 @@
+fixes:
+  # Remap from npm-installed ts-node to root of project
+  # This can take the place of ./scripts/rewrite-coverage-paths.js
+  - "tests/node_modules/ts-node/::"

package.json

@@ -29,8 +29,10 @@
     "build-configSchema": "typescript-json-schema --topRef --refs --validationKeywords allOf --out tsconfig.schema.json tsconfig.json TsConfigSchema && node --require ./register ./scripts/create-merged-schema",
     "build-pack": "node ./scripts/build-pack.js",
     "test-spec": "mocha dist/**/*.spec.js -R spec --bail",
-    "test-cov": "nyc mocha -- \"dist/**/*.spec.js\" -R spec --bail && node ./scripts/rewrite-coverage-paths.js && nyc report --reporter=lcov",
+    "test-cov": "nyc mocha -- \"dist/**/*.spec.js\" -R spec --bail",
     "test": "npm run build && npm run lint && npm run test-cov",
+    "coverage-fix-paths": "node ./scripts/rewrite-coverage-paths.js",
+    "coverage-report": "nyc report --reporter=lcov",
     "prepare": "npm run build-nopack"
   },
   "engines": {