Skip to content

WIP: Show original TS internal error (Fixes #824) #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

simonbuchan
Copy link

@simonbuchan simonbuchan commented Aug 29, 2018

See #824 for details.

Works around webpack catching thrown errors from the loader hook, and pushing them to compilation.errors, but not from the after-compile hook, meaning some internal TS errors get hidden by a different error.

@johnnyreilly
Copy link
Member

Thanks for the PR! Unfortunately this breaks some of the error reporting; the comparison test for errors being a case in point. Would you like to try a different approach?

BTW is it worth splitting out the example into a separate PR or does it require your change to work?

@simonbuchan
Copy link
Author

Yep, I expected pretty much something like that, hence it being a WIP hack 😉

The example is in a seperate commit deliberately so it could be pulled out, but I threw it in in case you would like having a repro ready to go. (You might notice it's using the local package like the test cases unlike the other examples)

As I described in the issue, I'm not sure what the right approach is here yet. If you have some ideas given that description of what's happening in happy to give it a try, or I'll do some experimenting.

But a bit late for me here tonight!

@johnnyreilly
Copy link
Member

or I'll do some experimenting

Experiment away! I'm on my holidays right now but I'll be watching with interest 😁

@johnnyreilly
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants