-
Notifications
You must be signed in to change notification settings - Fork 203
Import syntax highlighting from Microsoft’s repo #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More info: It's a little script that's pulling the raw files from GitHub, reading as YAML, adding the custom grammar rules before the other rules (in |
"cson": "^3.0.2", | ||
"js-yaml": "^3.5.2", | ||
"mz": "^2.1.0", | ||
"popsicle": "^3.0.1", | ||
"typings": "^0.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfectly fine and thank you 👍 💯 . Just wanted to share that atom does install devDependencies
on user machines for whatever reason. That's why we had to remove grunt
/ grunt-ts
. Leaving these in shouldn't be a problem though 🌹 Again just sharing past experiences 🌹
] | ||
|
||
Promise.all([ | ||
request('https://raw.githubusercontent.com/Microsoft/TypeScript-TmLanguage/master/TypeScript.YAML-tmLanguage'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌹 💯
@blakeembrey merge or let me merge. Love you! 🌹 |
Absolutely, all yours! On the Angular template, I wonder if there's a better way to detect HTML and switch to HTML within strings. Maybe if the string begins with |
Import syntax highlighting from Microsoft’s repo
Way to go! |
Great! |
Figured it's about time we close #675.