tsconfig.json keeps getting converted to Unix line endings

[joelspadin]

When I have tsconfig.json saved with Windows-style line endings (CRLF), and then I do almost anything within Atom (open a file, save a file, etc.), the file is rewritten with Unix-style line endings (LF). This is frustrating when your Git environment is set to check out files with Windows-style line endings.

[basarat]

sorry about that. Fixed with v1.14.0 ❤️

[joelspadin]

Thanks!

[msssk]

For those of us who prefer LF, the "fixed" behavior is undesirable. I think this issue cannot be resolved to everyone's satisfaction until Atom itself is fixed - it uses LF, and has no option to change it. Atom should have a user preference for line endings, and atom-typescript should adopt that.

In the meantime, I feel like Atom packages should do what Atom does (LF).

@ChaosinaCan how do you handle editing code with Atom if you prefer CRLF? I use Atom on Windows and it always uses LF (which is fine by me, but it really should be configurable).

[basarat]

it uses LF

No, it takes a majority vote based on the contents of the file (I know for sure). If file is empty it uses os.EOL (I think).

[msssk]

If file is empty it uses os.EOL (I think).

For new files, I am on Windows, and it uses LF. So it only adopts something other than LF if you open an existing file with different line endings.

[basarat]

For new files, I am on Windows, and it uses LF. S

You are right. Sorry. My bad.

[joelspadin]

Correct. Atom appears to default to LF, but after I convert the file to CRLF, it uses CRLF from then on.

[msssk]

Clearly, the rational thing to do is to follow suit from Atom and scan every file listed in tsconfig.json, count the line endings, tally the winner, and use that in tsconfig.json!

Or add your thoughts on the Atom issue:
atom/atom#2822

[joelspadin]

Heh. Maybe a more rational way to follow Atom's behavior would be: if tsconfig.json doesn't exist, create it with LF. If it does exist, check what the first line ending in the file is and use that when you rewrite it.

[basarat]

Maybe a more rational way to follow Atom's behavior would be: if tsconfig.json doesn't exist, create it with LF. If it does exist, check what the first line ending in the file is and use that when you rewrite it.

@msssk if you agree create a new issue here for tracking (up for grabs). I am okay with this 👍

[msssk]

I'd really like to see Atom make this user-configurable, but in the meantime if we can maintain the existing line endings I can at least update my atom-typescript package past 1.13!

I created #224 for this.