Skip to content

Feat: (proposal) prop validation. #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/editor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"@blocknote/core": "^0.8.1",
"@blocknote/react": "^0.8.1",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^18.2.0",
"zod": "^3.21.4"
},
"devDependencies": {
"@types/react": "^18.0.25",
Expand Down
69 changes: 68 additions & 1 deletion examples/editor/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,82 @@
// import logo from './logo.svg'
import { z } from 'zod';
import { DefaultBlockSchema, defaultBlockSchema } from '@blocknote/core';
import { BlockNoteView, useBlockNote, createReactBlockSpec, ReactSlashMenuItem, defaultReactSlashMenuItems } from "@blocknote/react";
import "@blocknote/core/style.css";
import { BlockNoteView, useBlockNote } from "@blocknote/react";
import styles from "./App.module.css";

export const AccordionBlock = createReactBlockSpec({
type: 'accordion',
propSchema: z.object({
label: z.string(),
autoLayout: z.object({
enabled: z.boolean(),
}).optional(),
}),
render: ({ editor, block }) => {
return (
<>
<h2 className='mb-2'>{block.props.label}</h2>
{
block.props.autoLayout?.enabled ?
(
<div className='flex flex-col'>
Enabled
</div>
) :
<></>
}
</>
);
},
containsInlineContent: false,
});

// Creates a slash menu item for inserting an image block.
export const insertAccordion = new ReactSlashMenuItem<
DefaultBlockSchema & { accordion: typeof AccordionBlock }
>(
'Insert Accordion',
(editor) => {
editor.insertBlocks(
[
// Default values are set here
{
type: 'accordion',
props: {
label: 'Default',
autoLayout: {
enabled: true
}
},
},
],
editor.getTextCursorPosition().block,
'before'
);
},
['accordion'],
'Containers',
<>+</>,
'Used to group content in an accordion.'
);


type WindowWithProseMirror = Window & typeof globalThis & { ProseMirror: any };

function App() {
const editor = useBlockNote({
onEditorContentChange: (editor) => {
console.log(editor.topLevelBlocks);
},
blockSchema: {
...defaultBlockSchema,
accordion: AccordionBlock,
},
slashCommands: [
...defaultReactSlashMenuItems,
insertAccordion
],
editorDOMAttributes: {
class: styles.editor,
"data-test": "editor",
Expand Down
14 changes: 12 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@
"uuid": "^8.3.2",
"y-prosemirror": "1.0.20",
"y-protocols": "^1.0.5",
"yjs": "^13.6.1"
"yjs": "^13.6.1",
"zod": "^3.21.4"
},
"devDependencies": {
"@types/hast": "^2.3.4",
Expand Down
Loading