Skip to content

alternative way to pass darkmode #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 15, 2023

Conversation

YousefED
Copy link
Collaborator

this is an alternative way to get darkmode info. I think this should simplify things.

Now, it's used to control showLineNumbers, which doesn't make any sense, but you should be able to adjust it to pass information to the demo (by adding a theme file similar to what you did before)

@YousefED YousefED requested a review from matthewlipski June 12, 2023 15:13
@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocknote-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 0:46am

@YousefED YousefED merged commit f380a7a into website-dark-mode Jun 15, 2023
matthewlipski added a commit that referenced this pull request Jun 15, 2023
* Made it possible for demos inherit website theme

* Made hero demo change theme automatically and adjusted dark bg color

* alternative way to pass darkmode (#239)

* alternative way to pass darkmode

* new isDark approached

* Updated theme shades

* Added dark mode sponsor logos

* Fixed dark mode sponsor logos

* Cleaned up sandbox dark mode implementation

* Added new features gifs

* Updated colors & styles

* Added dark mode switching to remaining demos

* Added dark mode screenshots

* Fixed theme switching in home page

* Adjusted features gifs

* Added collaboration gifs

* Fixed home page demo theme switching

* Adjusted styles

* Small fixes

---------

Co-authored-by: Matthew Lipski <[email protected]>

* fix package json

---------

Co-authored-by: Yousef <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants