alternative way to pass darkmode #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewlipski
added a commit
that referenced
this pull request
Jun 15, 2023
* Made it possible for demos inherit website theme * Made hero demo change theme automatically and adjusted dark bg color * alternative way to pass darkmode (#239) * alternative way to pass darkmode * new isDark approached * Updated theme shades * Added dark mode sponsor logos * Fixed dark mode sponsor logos * Cleaned up sandbox dark mode implementation * Added new features gifs * Updated colors & styles * Added dark mode switching to remaining demos * Added dark mode screenshots * Fixed theme switching in home page * Adjusted features gifs * Added collaboration gifs * Fixed home page demo theme switching * Adjusted styles * Small fixes --------- Co-authored-by: Matthew Lipski <[email protected]> * fix package json --------- Co-authored-by: Yousef <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an alternative way to get darkmode info. I think this should simplify things.
Now, it's used to control
showLineNumbers, which doesn't make any sense, but you should be able to adjust it to pass information to the demo (by adding a theme file similar to what you did before)