fix: dragging multiple blocks #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewlipski
approved these changes
Apr 18, 2023
fogle
pushed a commit
to fogle/BlockNote
that referenced
this pull request
May 20, 2023
* fix: dragging blocks with the same type and content * fix: dragging blocks after dropped outside the editor * Code style fix --------- Co-authored-by: Matthew Lipski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #80
Nodes eq method returns true if the two nodes are either the same instance or if their markup and content is the same. In this case the markup or content of the Nodes do not matter and the condition should only be true when the instance is not the same.
When dropping a selection of multiple blocks outside of the editor the selection type stays the same as it got set here. If the selection gets dragged again and is of type
MultipleNodeSelectionwe can be sure that the user drags multiple blocks at once.