Pass blockId to uploadFile in UploadTab #1641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements change proposed in #1637
Changes
Inside the
UploadTab
, pass the block id as parameter to theeditor.uploadFile
function as expected in the function docI also suggested a small variable renaming inside the uploadFule function of the editor because in the rest of the code and docs,
bloc
referres to an editor bloc which is an object but uploadFile expects a string as an input the blockId