fix: Link toolbar update error #1486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mouseover` handler
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Mar 4, 2025
| @@ -190,7 +190,7 @@ class LinkToolbarView implements PluginView { | |||
| } | |||
| } | |||
|
|
|||
| update(view: EditorView, oldState?: EditorState) { | |||
| update(view: EditorView, oldState?: EditorState, fromMouseOver = false) { | |||
There was a problem hiding this comment.
Am I crazy to think that no one else is calling this update method?
There was a problem hiding this comment.
Ah this is part of the PluginView spec from ProseMirror, it automatically gets called on state updates (https://prosemirror.net/docs/ref/#state.PluginView). It's just harder to see that since in our case the view does a lot of stuff.
There was a problem hiding this comment.
Also I guess normally you'd pass in a plain object, so the fact that we're using a class also obfuscates things
There was a problem hiding this comment.
Ohh ok. Eh, this definitely is a hack. But, I think it is okay for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an bug with the link toolbar, where
mouseHoveredLinkMarkmay be defined even when the mouse cursor isn't hovering any links. This is because the plugin would check if a link is currently hovered by the keyboard or mouse on every state update. State updates may cause the link under the mouse cursor move or be removed outright (such as moving blocks up & down, where it's briefly removed when replacing blocks). However, as nomouseoverevent is fired,mouseHoveredLinkMarkdoesn't get cleared and so an error is thrown if the link doesn't exist.Therefore, this PR changes the behaviour so that only
keyboardHoveredLinkMarkis considered when updating the link toolbar, unless the update was explicitly called by themouseoverhandler.Closes #1479