fix: Mantine CSS variables element #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Feb 25, 2025
nperez0111
reviewed
Feb 25, 2025
|
Ok so I was also getting confused and not exactly understanding what's going on - @nperez0111 you're right in your comments, I added |
nperez0111
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mantine theme CSS variables aren't being set properly at the moment, which means that an editor using the Mantine
BlockNoteViewmay not have the CSS variables it needs when not within an existingMantineProvider. This is becausegetRootElementreturns no element, but we need it to setdata-mantine-color-schemeon the.bn-mantineelement. Since it's a child of theMantineProviderand can't be found on render, we have to setdata-mantine-color-schememanually throughBlockNoteViewRaw.We pretty much never use Mantine theme variables as we use the BlockNote theme variables instead, but the
Badgecomponents from the comments PR does use them. Maybe we also want to change this to use strictly BlockNote theme variables? (ofc in the comments PR, not this one)