-
-
Notifications
You must be signed in to change notification settings - Fork 555
fix: chrome should not wrap mid-line #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
12e8a31
fix: chrome should not wrap mid-line
nperez0111 1792526
revert: "fix: chrome should not wrap mid-line"
nperez0111 c5df050
fix: chrome should not wrap mid-line
nperez0111 8cdd392
fix: offset by 2px to not take up space within the element
nperez0111 930c9f9
chore: disable user-select on the label
nperez0111 20a4958
chore: fix for safari to display cursor caret
nperez0111 5728d4a
chore: add comments
nperez0111 cb41942
fix: firefox specific bug fix
nperez0111 c269a2f
fix: update the position of the open label and comments
nperez0111 8a8ed59
chore: update typo
nperez0111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,7 @@ export const createCollaborationExtensions = (collaboration: { | |
const cursorElement = document.createElement("span"); | ||
|
||
cursorElement.classList.add("collaboration-cursor__caret"); | ||
cursorElement.setAttribute("style", `outline-color: ${user.color}`); | ||
cursorElement.setAttribute("style", `color: ${user.color}`); | ||
if (collaboration?.showCursorLabels === "always") { | ||
cursorElement.setAttribute("data-active", ""); | ||
} | ||
|
@@ -77,9 +77,7 @@ export const createCollaborationExtensions = (collaboration: { | |
labelElement.setAttribute("style", `background-color: ${user.color}`); | ||
labelElement.insertBefore(document.createTextNode(user.name), null); | ||
|
||
cursorElement.insertBefore(document.createTextNode("\u2060"), null); // Non-breaking space | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We now let CSS insert these |
||
cursorElement.insertBefore(labelElement, null); | ||
cursorElement.insertBefore(document.createTextNode("\u2060"), null); // Non-breaking space | ||
|
||
return cursorElement; | ||
}; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one is here? Github doesn't show it
nbsp = https://www.compart.com/en/unicode/U+00A0
word joiner = https://www.compart.com/en/unicode/U+2060
the previous code had "word joiner"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
word joiner is there. I'll update the comment with the unicode to make it clear