Changed: Fixed large buffer rent caused by the default implementation of Stream.Read(Span<byte>)

Changed: Nuget package publishing
Changed: Bump package version
Removed: qodana.yml
Removed: NOTICE.md reference

Signed-off-by: JOSE FUXA <[email protected]>

Author: j-fuxa

.editorconfig

@@ -1,5 +1,4 @@
-# EditorConfig is awesome:
-http://EditorConfig.org
+# EditorConfig is awesome: http://EditorConfig.org
 
 # top-most EditorConfig file
 root = true
@@ -12,6 +11,8 @@ trim_trailing_whitespace = true
 
 # C# files
 [*.cs]
+charset = utf-8
+
 # New line preferences
 csharp_new_line_before_open_brace = none
 csharp_new_line_before_catch = false
@@ -21,6 +22,13 @@ csharp_new_line_before_members_in_anonymous_types = false
 csharp_new_line_before_members_in_object_initializers = false
 csharp_new_line_within_query_expression_clauses = true
 
+# use file-scoped namespaces
+csharp_style_namespace_declarations = file_scoped
+dotnet_diagnostic.IDE0161.severity = error
+
+# use ValueTasks correctly
+dotnet_diagnostic.CA2012.severity = error
+
 # Indentation preferences
 csharp_indent_block_contents = true
 csharp_indent_braces = false

.github/workflows/qodana.yml

@@ -3,6 +3,11 @@ on:
   push:
     tags:
       - "v*"
+
+permissions:
+    contents: read
+    packages: write
+
 jobs:
   release:
     runs-on: ubuntu-latest
@@ -22,7 +27,7 @@ jobs:
       - name: Build, Pack and Publish
         run: |
           dotnet pack /p:Version=${{ steps.get_version.outputs.version }} -o artefacts -c Release src/EventStore.Plugins/EventStore.Plugins.csproj
-          dotnet nuget push artefacts/EventStore.Plugins.${{ steps.get_version.outputs.version }}.nupkg -k ${{ secrets.nugetkey }} -s https://api.nuget.org/v3/index.json
+          dotnet nuget push artefacts/EventStore.Plugins.${{ steps.get_version.outputs.version }}.nupkg --api-key "${{ secrets.GITHUB_TOKEN }}" --source "https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json"
       - name: Create Release
         id: create_release
         uses: actions/create-release@v1

.github/workflows/release.yml

@@ -12,7 +12,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		.editorconfig = .editorconfig
 		.gitignore = .gitignore
 		LICENSE.md = LICENSE.md
-		NOTICE.md = NOTICE.md
 		qodana.yaml = qodana.yaml
 		README.md = README.md
 	EndProjectSection

EventStore.Plugins.sln

@@ -4,7 +4,7 @@ namespace EventStore.Plugins.Authentication;
 
 public abstract class AuthenticationProviderBase(PluginOptions options) : Plugin(options), IAuthenticationProvider {
 	protected AuthenticationProviderBase(
-		string? name = null, 
+		string? name = null,
 		string? version = null,
 		string? licensePublicKey = null,
 		string? diagnosticsName = null,
@@ -22,8 +22,8 @@ protected AuthenticationProviderBase(
 	public abstract void Authenticate(AuthenticationRequest authenticationRequest);
 
 	public virtual IEnumerable<KeyValuePair<string, string>> GetPublicProperties() => [];
-	
+
 	public virtual void ConfigureEndpoints(IEndpointRouteBuilder endpointRouteBuilder) { }
 
 	public virtual IReadOnlyList<string> GetSupportedAuthenticationSchemes() => [];
-}
+}

src/EventStore.Plugins/Authentication/AuthenticationProviderBase.cs

@@ -1,4 +1,4 @@
-using System.Security.Claims;
+using System.Security.Claims;
 
 namespace EventStore.Plugins.Authentication;
 
@@ -66,4 +66,4 @@ protected AuthenticationRequest(string? id, IReadOnlyDictionary<string, string>?
 	///     The authentication provider is not yet ready to service the request
 	/// </summary>
 	public abstract void NotReady();
-}
+}

src/EventStore.Plugins/Authentication/AuthenticationRequest.cs

@@ -58,4 +58,4 @@ public override void NotReady() =>
 
 	public Task<(HttpAuthenticationRequestStatus, ClaimsPrincipal?)> AuthenticateAsync() =>
 		_tcs.Task;
-}
+}

src/EventStore.Plugins/Authentication/HttpAuthenticationRequest.cs

@@ -1,4 +1,4 @@
-namespace EventStore.Plugins.Authentication;
+namespace EventStore.Plugins.Authentication;
 
 public interface IAuthenticationPlugin {
 	string Name { get; }
@@ -10,4 +10,4 @@ public interface IAuthenticationPlugin {
 	/// </summary>
 	/// <param name="authenticationConfigPath">The path to the configuration file for the authentication plugin</param>
 	IAuthenticationProviderFactory GetAuthenticationProviderFactory(string authenticationConfigPath);
-}
+}

src/EventStore.Plugins/Authentication/IAuthenticationPlugin.cs

@@ -1,4 +1,4 @@
-using Microsoft.AspNetCore.Routing;
+using Microsoft.AspNetCore.Routing;
 
 namespace EventStore.Plugins.Authentication;
 
@@ -30,4 +30,4 @@ public interface IAuthenticationProvider : IPlugableComponent {
 	///     Get supported authentication schemes.
 	/// </summary>
 	IReadOnlyList<string> GetSupportedAuthenticationSchemes();
-}
+}

src/EventStore.Plugins/Authentication/IAuthenticationProvider.cs

@@ -8,4 +8,4 @@ public interface IAuthenticationProviderFactory {
 	///     Whether the Authentication Provider should log failed authentication attempts
 	/// </param>
 	IAuthenticationProvider Build(bool logFailedAuthenticationAttempts);
-}
+}