hooked new settings window to actual values #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Dec 15, 2021
| @@ -40,19 +40,6 @@ | |||
| <property name="modal"> | |||
| <bool>false</bool> | |||
| </property> | |||
| <widget class="QDialogButtonBox" name="save_cancel_dialog_button_box"> | |||
There was a problem hiding this comment.
You mentioned you may prefer having a Save/Cancel button. I personally think having the settings instantly be reflected is preferable. Try it out, and if not I'll add them back with save/cancel logic.
Avasam
commented
Dec 15, 2021
Comment on lines
+96
to
+99
| <number>20</number> | ||
| </property> | ||
| <property name="maximum"> | ||
| <double>5000.000000000000000</double> | ||
| </property> | ||
| <property name="singleStep"> | ||
| <double>1.000000000000000</double> | ||
| <number>240</number> |
There was a problem hiding this comment.
Why these numbers make sense:
OOT runs at 20 visual frames during gameplay
No consumer monitor runs above 240hz, which is 0.00416ms, another option is to cap at 1000FPS for precision down to the milisecond. If anyone's computer can even realistically handle that.
This was referenced Dec 15, 2021
Merged
Updated a few inaccurate docs
Also untangled __auto_splitter function
Fixes #21 Updated some doc max fps will show `...` while working
- Use win32gui.IsWindow for hwnd checks - is_valid_image TypeGuard
Camera capture split cam option
|
Closed in favor of #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.