Skip to content

Commit b90ec1f

Browse files
committed
Redundant flake8-isort
1 parent b5484bc commit b90ec1f

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

.github/workflows/lint-and-build.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,23 @@ env:
3535
GITHUB_EXCLUDE_BUILD_NUMBER: ${{ inputs.excludeBuildNumber }}
3636

3737
jobs:
38+
isort:
39+
runs-on: windows-latest
40+
steps:
41+
- name: Checkout ${{ github.repository }}/${{ github.ref }}
42+
uses: actions/checkout@v3
43+
- name: Set up Python 3.11
44+
uses: actions/setup-python@v4
45+
with:
46+
python-version: "3.11"
47+
cache: "pip"
48+
cache-dependency-path: "scripts/requirements*.txt"
49+
- run: scripts/install.ps1
50+
shell: pwsh
51+
- run: (Get-Command pyuic6).Source
52+
shell: pwsh
53+
- name: Analysing the code with add-trailing-comma
54+
run: isort src/ typings/ --check-only
3855
add-trailing-comma:
3956
runs-on: windows-latest
4057
steps:

.vscode/settings.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@
7272
},
7373
"python.formatting.provider": "autopep8",
7474
"python.analysis.diagnosticMode": "workspace",
75+
"isort.check": true,
76+
"isort.importStrategy": "fromEnvironment",
7577
"python.linting.enabled": true,
7678
// Use the new Pylint extension instead
7779
"python.linting.pylintEnabled": false,

scripts/requirements-dev.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ flake8-bugbear
1414
flake8-class-attributes-order
1515
flake8-comprehensions>=3.8 # flake8 5 support
1616
flake8-datetimez
17-
flake8-isort>=4.2,<=5.0 # flake8 5 support # Breaking issue (https://github.com/gforcada/flake8-isort/issues/128)
1817
flake8-pyi>=22.11.0 # flak8 6 support
1918
flake8-quotes
2019
flake8-simplify

0 commit comments

Comments
 (0)