Async check for updates

Author: Avasam

.vscode/settings.json

@@ -33,7 +33,7 @@
   // Maybe consider PyLint once all Flake8 linting is fixed
   "python.linting.pylintEnabled": false,
   "python.linting.flake8Enabled": true,
-  "python.linting.mypyEnabled": true,
+  "python.linting.mypyEnabled": false,
   // Flake8 is already a pycodestyle wrapper
   "python.linting.pycodestyleEnabled": false,
   "python.linting.pylintArgs": [
@@ -44,9 +44,6 @@
   "python.linting.flake8Args": [
     "--max-line-length=120"
   ],
-  "python.linting.mypyArgs": [
-    "--max-line-length=120"
-  ],
   "python.formatting.autopep8Args": [
     "--max-line-length=120"
   ],

scripts/requirements.txt

@@ -20,8 +20,8 @@ packaging
 pyautogui
 PySide6
 flake8
-mypy
 requests
+types-requests
 #
 # Comment this out if you don't want to build AutoSplit.exe:
 PyInstaller

src/AutoSplit.py

@@ -15,7 +15,7 @@
 import time
 
 from menu_bar import about, VERSION, viewHelp, checkForUpdates
-from settings_file import auto_split_directory
+from settings_file import auto_split_directory, open_update_checker
 from split_parser import BELOW_FLAG, DUMMY_FLAG, PAUSE_FLAG
 import capture_windows
 import compare
@@ -52,6 +52,7 @@ class AutoSplit(QtWidgets.QMainWindow, design.Ui_MainWindow):
     undoSplitSignal = QtCore.pyqtSignal()
     pauseSignal = QtCore.pyqtSignal()
     afterSettingHotkeySignal = QtCore.pyqtSignal()
+    updateCheckerWidgetSignal = QtCore.pyqtSignal(str, bool)
 
     def __init__(self, parent=None):
         super(AutoSplit, self).__init__(parent)
@@ -167,6 +168,8 @@ def run(self):
         self.updateCurrentSplitImage.connect(self.updateSplitImageGUI)
         self.afterSettingHotkeySignal.connect(self.afterSettingHotkey)
         self.startAutoSplitterSignal.connect(self.autoSplitter)
+        self.updateCheckerWidgetSignal.connect(lambda latest_version, check_on_open:
+                                               open_update_checker(self, latest_version, check_on_open))
         self.resetSignal.connect(self.reset)
         self.skipSplitSignal.connect(self.skipSplit)
         self.undoSplitSignal.connect(self.undoSplit)

src/menu_bar.py

@@ -4,10 +4,13 @@
     from AutoSplit import AutoSplit
 
 import os
-from PyQt6 import QtWidgets
 
-import requests
 from packaging import version
+from PyQt6 import QtWidgets
+from PyQt6.QtCore import QThread
+from requests.exceptions import RequestException
+from simplejson.errors import JSONDecodeError
+import requests
 
 import about
 import design
@@ -17,11 +20,11 @@
 import update_checker
 
 # AutoSplit Version number
-VERSION = "1.5.0"
+VERSION = "1.6.1"
 
 
 # About Window
-class AboutWidget(QtWidgets.QWidget, about.Ui_aboutAutoSplitWidget):
+class __AboutWidget(QtWidgets.QWidget, about.Ui_aboutAutoSplitWidget):
     def __init__(self):
         super().__init__()
         self.setupUi(self)
@@ -31,7 +34,11 @@ def __init__(self):
         self.show()
 
 
-class UpdateCheckerWidget(QtWidgets.QWidget, update_checker.Ui_UpdateChecker):
+def about(self: AutoSplit):
+    self.AboutWidget = __AboutWidget()
+
+
+class __UpdateCheckerWidget(QtWidgets.QWidget, update_checker.Ui_UpdateChecker):
     def __init__(self, latest_version: str, design_window: design.Ui_MainWindow, check_on_open: bool = False):
         super().__init__()
         self.setupUi(self)
@@ -61,19 +68,30 @@ def doNotAskMeAgainStateChanged(self):
             self.checkBoxDoNotAskMeAgain.isChecked())
 
 
+def open_update_checker(autosplit: AutoSplit, latest_version: str, check_on_open: bool):
+    autosplit.UpdateCheckerWidget = __UpdateCheckerWidget(latest_version, autosplit, check_on_open)
+
+
 def viewHelp():
     os.system("start \"\" https://github.com/Toufool/Auto-Split#tutorial")
 
 
-def about(self: AutoSplit):
-    self.AboutWidget = AboutWidget()
+class __CheckForUpdatesThread(QThread):
+    def __init__(self, autosplit: AutoSplit, check_on_open: bool):
+        super().__init__()
+        self.autosplit = autosplit
+        self.check_on_open = check_on_open
+
+    def run(self):
+        try:
+            response = requests.get("https://api.github.com/repos/Toufool/Auto-Split/releases/latest")
+            latest_version = response.json()["name"].split("v")[1]
+            self.autosplit.updateCheckerWidgetSignal.emit(latest_version, self.check_on_open)
+        except (RequestException, KeyError, JSONDecodeError):
+            if not self.check_on_open:
+                error_messages.checkForUpdatesError()
 
 
 def checkForUpdates(autosplit: AutoSplit, check_on_open: bool = False):
-    try:
-        response = requests.get("https://api.github.com/repos/Toufool/Auto-Split/releases/latest")
-        latest_version = response.json()["name"].split("v")[1]
-        autosplit.UpdateCheckerWidget = UpdateCheckerWidget(latest_version, autosplit, check_on_open)
-    except:
-        if not check_on_open:
-            error_messages.checkForUpdatesError()
+    autosplit.CheckForUpdatesThread = __CheckForUpdatesThread(autosplit, check_on_open)
+    autosplit.CheckForUpdatesThread.start()