Server stop hang on android

[kishanDevani]

how i do it....

[DeHecht]

i faced the same problem #191 may this help you?

[Davidiusdadi]

hang has been fixed
see #191

[kishanDevani]

hi......
i not clear ....
please help me....

[kishanDevani]

this web socket server work very well but problem only occurs when stooping them...

[Davidiusdadi]

Do you work on the latest revision?

I will try to reproduce the problem within the next few days.

[DeHecht]

One of our testers reproduced an deadlock within the library.

"WebsocketSelector328":
    at org.java_websocket.server.WebSocketServer.removeConnection(WebSocketServer.java:519)
    - waiting to lock <0x00000007ae49fcd8> (a java.util.HashSet)
    at org.java_websocket.server.WebSocketServer.onWebsocketClose(WebSocketServer.java:498)
    at org.java_websocket.WebSocketImpl.closeConnection(WebSocketImpl.java:470)
    - locked <0x00000007ae555d00> (a org.java_websocket.WebSocketImpl)
    at org.java_websocket.WebSocketImpl.closeConnection(WebSocketImpl.java:490)
    at org.java_websocket.SocketChannelIOHelper.batch(SocketChannelIOHelper.java:64)
    - locked <0x00000007ae555d00> (a org.java_websocket.WebSocketImpl)
    at org.java_websocket.server.WebSocketServer.run(WebSocketServer.java:349)
    at java.lang.Thread.run(Thread.java:662)
"main":
    at org.java_websocket.WebSocketImpl.flushAndClose(WebSocketImpl.java:498)
    - waiting to lock <0x00000007ae555d00> (a org.java_websocket.WebSocketImpl)
    at org.java_websocket.WebSocketImpl.close(WebSocketImpl.java:424)
    at org.java_websocket.WebSocketImpl.close(WebSocketImpl.java:537)
    at org.java_websocket.server.WebSocketServer.stop(WebSocketServer.java:209)
    - locked <0x00000007ae49fcd8> (a java.util.HashSet)

so my suggested quick solution would be to replace

synchronized ( connections ) {
    for(WebSocket ws : socketsToClose) {
        ws.close( CloseFrame.GOING_AWAY );
    }
}

with

List<WebSocket> socketsToClose = null;

// copy the connections in a list (prevent callback deadlocks)
synchronized ( connections ) {
    socketsToClose = new ArrayList<WebSocket>(connections);
}

for(WebSocket ws : socketsToClose) {
    ws.close( CloseFrame.GOING_AWAY );
}

this way the HashSet would not get accessed by two different threads at the same time resulting into the deadlock.

[kishanDevani]

it still hang app on android, today i replace all new code....!

[kishanDevani]

i am working on this app....!

https://play.google.com/store/apps/details?id=com.spidren.inc

[kishanDevani]

it now hang on when not conected any clicent..!

[bendem]

Probably fixed by #329

[marci4]

Looks like this issue is fixed with #329

Closing!
Greetings
marci4