Skip to content

Don't delete expired snapshots or environments records unless their associated data objects have been deleted #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
izeigerman opened this issue Mar 30, 2025 · 0 comments · May be fixed by #4228
Labels
Improvement Improves existing functionality

Comments

@izeigerman
Copy link
Member

We currently delete environment/snapshot records first, and only then do we attempt to clean up the views/tables associated with them.

This means that if a view or table deletion fails for any reason, the deletion process won't be reattempted later, as any information about its existence has already been removed from the state.

We need to change the order of operations and delete a record from the state only after the associated data object has been successfully deleted.

@izeigerman izeigerman added the Improvement Improves existing functionality label Mar 30, 2025
@izeigerman izeigerman changed the title Don't delete expired snapshots / environments unless data objects associated with them have been deleted Don't delete expired snapshots or environments records unless their associated data objects have been deleted Mar 30, 2025
@VaggelisD VaggelisD linked a pull request Apr 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improves existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant