-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Add h index #8036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add h index #8036
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
""" | ||
Task: | ||
Given an array of integers citations where citations[i] is the number of | ||
citations a researcher received for their ith paper, return compute the | ||
researcher's h-index. | ||
|
||
According to the definition of h-index on Wikipedia: A scientist has an | ||
index h if h of their n papers have at least h citations each, and the other | ||
n - h papers have no more than h citations each. | ||
|
||
If there are several possible values for h, the maximum one is taken as the | ||
h-index. | ||
|
||
H-Index link: https://en.wikipedia.org/wiki/H-index | ||
|
||
Implementation notes: | ||
Use sorting of array | ||
|
||
Leetcode link: https://leetcode.com/problems/h-index/description/ | ||
|
||
n = len(citations) | ||
Runtime Complexity: O(n * log(n)) | ||
Space Complexity: O(1) | ||
|
||
""" | ||
|
||
|
||
def h_index(citations: list[int]) -> int: | ||
""" | ||
Return H-index of citations | ||
|
||
>>> h_index([3, 0, 6, 1, 5]) | ||
3 | ||
>>> h_index([1, 3, 1]) | ||
1 | ||
>>> h_index([1, 2, 3]) | ||
2 | ||
>>> h_index('test') | ||
Traceback (most recent call last): | ||
... | ||
ValueError: The citations should be a list of non negative integers. | ||
>>> h_index([1,2,'3']) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: The citations should be a list of non negative integers. | ||
>>> h_index([1,2,-3]) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: The citations should be a list of non negative integers. | ||
""" | ||
|
||
# validate: | ||
if not isinstance(citations, list) or not all( | ||
[isinstance(item, int) and item >= 0 for item in citations] | ||
): | ||
raise ValueError("The citations should be a list of non negative integers.") | ||
|
||
citations.sort() | ||
len_citations = len(citations) | ||
|
||
for i in range(len_citations): | ||
if citations[len_citations - 1 - i] <= i: | ||
return i | ||
|
||
return len_citations | ||
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
doctest.testmod() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.