Skip to content

Update is_palindrome.py #8022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 4, 2023
Merged

Update is_palindrome.py #8022

merged 7 commits into from
Jan 4, 2023

Conversation

abhishekmulik
Copy link
Contributor

Optimised the algorithm in terms of space from O(n) to O(1)

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@abhishekmulik
Update is_palindrome.py
97f85bb 
Algorithm optimised in terms of space from O(n) to O(1)
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Dec 7, 2022
CaedenPH
CaedenPH approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! @cclauss, what is your opinion?

@cclauss
Copy link
Member

cclauss commented Dec 7, 2022

Please keep both the old and new algorithms in a single file with a timeit benchmark that proves the optimization.
https://github.com/search?q=repo%3ATheAlgorithms%2FPython%20timeit&type=code

@alexpantyukhin
Copy link
Member

Awesome approvement!

@ChrisO345 ChrisO345 merged commit 32a1ff9 into TheAlgorithms:master Jan 4, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jan 4, 2023
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@abhishekmulik @Cjkjvfnby
Update is_palindrome.py (TheAlgorithms#8022)
2405a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@ChrisO345 ChrisO345 ChrisO345 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhishekmulik @cclauss @alexpantyukhin @CaedenPH @ChrisO345