-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
adding the remove digit algorithm #6708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f97cda9
adding the remove digit algorithm
meg-1 b9013e5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d4d1ef8
refactoring code
meg-1 c4b81c2
Apply suggestions from code review
cclauss a4a47ab
Update remove_digit.py
cclauss 2e1aa1a
fixing errors
meg-1 a493d79
fixing error C416
meg-1 80372da
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 96c317a
implementing contributors suggestions
meg-1 05f4d71
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
def remove_digit(num: int) -> int: | ||
""" | ||
|
||
returns the biggest possible result | ||
that can be achieved by removing | ||
one digit from the given number | ||
|
||
>>> remove_digit(152) | ||
52 | ||
>>> remove_digit(6385) | ||
685 | ||
>>> remove_digit(-11) | ||
1 | ||
>>> remove_digit(2222222) | ||
222222 | ||
>>> remove_digit("2222222") | ||
Traceback (most recent call last): | ||
TypeError: only integers accepted as input | ||
>>> remove_digit("string input") | ||
Traceback (most recent call last): | ||
TypeError: only integers accepted as input | ||
""" | ||
|
||
if isinstance(num, int): | ||
num_str = str(abs(num)) | ||
num_transpositions = [ | ||
[char for char in num_str] for char in range(len(num_str)) | ||
] | ||
for index in range(len(num_str)): | ||
num_transpositions[index].pop(index) | ||
return sorted( | ||
int("".join([char for char in transposition])) | ||
for transposition in num_transpositions, | ||
reverse=True | ||
] | ||
)[0] | ||
else: | ||
raise TypeError("only integers accepted as input") | ||
|
||
|
||
if __name__ == "__main__": | ||
__import__("doctest").testmod() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.