Skip to content

adding the dna algorithm #6323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2022
Merged

adding the dna algorithm #6323

merged 5 commits into from
Sep 5, 2022

Conversation

meg-1
Copy link
Contributor

@meg-1 meg-1 commented Aug 13, 2022

Describe your change:

added an algorithm, which: given one side of a DNA strand returns the other, complementary side of the same strand
how genomes work

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 13, 2022
meg-1 added 4 commits August 13, 2022 14:42
@meg-1
following bot recommendations
a309018 
following bot recommendations for the indentation
@meg-1
following bot recommendations
6d02a26 
following bot recommendations regarding indentation [ again ]
@meg-1
following bot recommendations
d1d8517 
following bot recommendations regarding indentation [ again. ]
@meg-1
following bot recommendations
5dd8f98 
following bot recommendations.
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 13, 2022
@meg-1
Copy link
Contributor Author

meg-1 commented Aug 27, 2022

@poyea hi! could you please check out this pull request??

1 similar comment
@meg-1
Copy link
Contributor Author

meg-1 commented Sep 3, 2022

@poyea hi! could you please check out this pull request??

poyea
poyea approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 5, 2022
@poyea poyea merged commit cbf3c61 into TheAlgorithms:master Sep 5, 2022
@appgurueu
Copy link

appgurueu commented Sep 9, 2022 •
edited
Loading

Thank you for your pull request!

How did this pass review? Consider this.

@meg-1
Copy link
Contributor Author

meg-1 commented Sep 14, 2022

Thank you for your pull request!🤩

thank you for accepting my changes! :)

@meg-1 meg-1 mentioned this pull request Oct 5, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-1 @appgurueu @poyea