Skip to content

edited strings/anagram.py #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

Leoriem-code
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Nov 4, 2021
@Leoriem-code Leoriem-code changed the title Strings/anagram.py edited Strings/anagram.py Nov 4, 2021
@Leoriem-code
Copy link
Contributor Author

Leoriem-code commented Nov 4, 2021

The build can't complete because the file anagrams.py use words.txt, file that is not accessible during build/test.

@cclauss
Copy link
Member

cclauss commented Nov 7, 2021

Take a look at

data: str = Path(__file__).parent.joinpath(filename).read_text(encoding="utf-8")

@cclauss cclauss changed the title edited Strings/anagram.py edited strings/anagram.py Nov 7, 2021
@Leoriem-code
Copy link
Contributor Author

Leoriem-code commented Nov 7, 2021

Thanks, let's hope it works
Thank you @cclauss

@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 7, 2021
Co-authored-by: Christian Clauss <[email protected]>
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have used pathlib for both reading and writing but let's land this one.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 8, 2021
@cclauss cclauss merged commit 4c9949f into TheAlgorithms:master Nov 8, 2021
@Leoriem-code Leoriem-code deleted the strings/anagram.py branch November 8, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants