-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
[Project Euler] Fix code style in Problem 41 #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: joan.rosellr <[email protected]>
Signed-off-by: joan.rosellr <[email protected]>
Signed-off-by: joan.rosellr <[email protected]>
Signed-off-by: joan.rosellr <[email protected]>
Signed-off-by: joan.rosellr <[email protected]>
If you're referring to this then this is not an assignment statement. The Example: >>> print(f"{1 + 2 = }")
1 + 2 = 3 For 2: leave it as it was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good increase of pythonicity and code documentation.
Signed-off-by: joan.rosellr <[email protected]>
Alright, I removed the extra function I added and left the old code as it was. |
The answer is actually the maximum value in the list but the function returns a list, we just need the value. Please make the necessary changes as required. |
Signed-off-by: joan.rosellr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
* add problem title and link, fix f-string Signed-off-by: joan.rosellr <[email protected]> * fix code style and improve doctests Signed-off-by: joan.rosellr <[email protected]> * undo changes to the main call Signed-off-by: joan.rosellr <[email protected]> * remove assignment operator in f-string Signed-off-by: joan.rosellr <[email protected]> * add newline after first import to attempt to fix pre-commit workflow Signed-off-by: joan.rosellr <[email protected]> * undo doctest changes, rename compute_pandigital_primes to solution Signed-off-by: joan.rosellr <[email protected]> * update solution to return the actual solution instead of a list Signed-off-by: joan.rosellr <[email protected]> * Update sol1.py Co-authored-by: Dhruv <[email protected]>
* add problem title and link, fix f-string Signed-off-by: joan.rosellr <[email protected]> * fix code style and improve doctests Signed-off-by: joan.rosellr <[email protected]> * undo changes to the main call Signed-off-by: joan.rosellr <[email protected]> * remove assignment operator in f-string Signed-off-by: joan.rosellr <[email protected]> * add newline after first import to attempt to fix pre-commit workflow Signed-off-by: joan.rosellr <[email protected]> * undo doctest changes, rename compute_pandigital_primes to solution Signed-off-by: joan.rosellr <[email protected]> * update solution to return the actual solution instead of a list Signed-off-by: joan.rosellr <[email protected]> * Update sol1.py Co-authored-by: Dhruv <[email protected]>
Describe your change:
Addresses #2786
I have some questions @dhruvmanila :
Checklist:
Fixes: #{$ISSUE_NO}
.