Skip to content

Hacktoberfest 2020: Rename method for project_euler/problem_99 #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2020
Merged

Hacktoberfest 2020: Rename method for project_euler/problem_99 #2981

merged 2 commits into from
Oct 7, 2020

Conversation

wenhongg
Copy link
Contributor

@wenhongg wenhongg commented Oct 7, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Travis tests have failed

Hey @wenhongg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: cdcd3a90-08a4-11eb-9b15-83942378e0dd

@wenhongg
Copy link
Contributor Author

wenhongg commented Oct 7, 2020

This PR addresses the issue mentioned in #2786 .

dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit ff9be86 into TheAlgorithms:master Oct 7, 2020
@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 7, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@wenhongg @stokhos
Hacktoberfest 2020: Rename method for project_euler/problem_99 (TheAl…
f77b945 
…gorithms#2981)

* name method solution in project_euler/problem99

* rename function
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@wenhongg
Hacktoberfest 2020: Rename method for project_euler/problem_99 (TheAl…
f692fe7 
…gorithms#2981)

* name method solution in project_euler/problem99

* rename function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenhongg @TravisBuddy @dhruvmanila