Skip to content

bring problem_30 solution in line with project style guidelines #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

bring problem_30 solution in line with project style guidelines #2896

merged 1 commit into from
Oct 6, 2020

Conversation

nthall
Copy link
Contributor

@nthall nthall commented Oct 6, 2020 •
edited
Loading

Describe your change:

Fixes issues with Project Euler problem 30 solution as described in #2786

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 6, 2020
dhruvmanila
dhruvmanila approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for doing this. 🎉 😃

@dhruvmanila dhruvmanila merged commit a56e548 into TheAlgorithms:master Oct 6, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@nthall @stokhos
Bring problem_30 solution in line with project style guidelines (TheA…
2f0c2c9 
…lgorithms#2896)
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@nthall
Bring problem_30 solution in line with project style guidelines (TheA…
c3396c8 
…lgorithms#2896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nthall @dhruvmanila