Skip to content

Commit 0794b6e

Browse files
vbreussvbreuss
authored
fix: failing build (#446)
Fix the failing build after #444: - Add the `test-report.yml` pipeline again - Downgrade the `upload-artifact` and `download-artifact` actions from v4 to v3 - Exclude the two actions from `renovate.json`
1 parent fd4d65b commit 0794b6e

File tree

6 files changed

+63
-17
lines changed

6 files changed

+63
-17
lines changed

‎.github/workflows/build.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
command: dotnet test --no-build --collect:"XPlat Code Coverage"
8585
attempt_limit: 2
8686
- name: Upload coverage
87-
uses: actions/upload-artifact@v4
87+
uses: actions/upload-artifact@v3
8888
with:
8989
name: Code coverage (MacOS)
9090
path: "**/coverage.cobertura.xml"
@@ -112,7 +112,7 @@ jobs:
112112
command: dotnet test --no-build --collect:"XPlat Code Coverage"
113113
attempt_limit: 2
114114
- name: Upload coverage
115-
uses: actions/upload-artifact@v4
115+
uses: actions/upload-artifact@v3
116116
with:
117117
name: Code coverage (Ubuntu)
118118
path: "**/coverage.cobertura.xml"
@@ -140,7 +140,7 @@ jobs:
140140
command: dotnet test --no-build --collect:"XPlat Code Coverage"
141141
attempt_limit: 2
142142
- name: Upload coverage
143-
uses: actions/upload-artifact@v4
143+
uses: actions/upload-artifact@v3
144144
with:
145145
name: Code coverage (Windows)
146146
path: "**/coverage.cobertura.xml"
@@ -206,17 +206,17 @@ jobs:
206206
with:
207207
fetch-depth: 0
208208
- name: Download code coverage files (MacOS)
209-
uses: actions/download-artifact@v4
209+
uses: actions/download-artifact@v3
210210
with:
211211
name: Code coverage (MacOS)
212212
path: Coverage/MacOS
213213
- name: Download code coverage files (Ubuntu)
214-
uses: actions/download-artifact@v4
214+
uses: actions/download-artifact@v3
215215
with:
216216
name: Code coverage (Ubuntu)
217217
path: Coverage/Ubuntu
218218
- name: Download code coverage files (Windows)
219-
uses: actions/download-artifact@v4
219+
uses: actions/download-artifact@v3
220220
with:
221221
name: Code coverage (Windows)
222222
path: Coverage/Windows

‎.github/workflows/ci-stryker.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
../../tools/dotnet-stryker -f ../.github/stryker/Stryker.Config.Testing.json -v "${GITHUB_HEAD_REF}" -r "html" -r "cleartext" --since:main
6262
mv ./StrykerOutput/**/reports/*.html ./StrykerOutput/Reports/Testably.Abstractions.Testing-report.html
6363
- name: Upload Stryker reports
64-
uses: actions/upload-artifact@v4
64+
uses: actions/upload-artifact@v3
6565
with:
6666
name: Stryker
6767
path: Tests/StrykerOutput/Reports/*

‎.github/workflows/ci.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ jobs:
3030
attempt_limit: 2
3131
- name: Upload test results (MacOS)
3232
if: ${{ always() }}
33-
uses: actions/upload-artifact@v4
33+
uses: actions/upload-artifact@v3
3434
with:
3535
name: Test results (MacOS)
3636
path: TestResults
3737
- name: Upload coverage
38-
uses: actions/upload-artifact@v4
38+
uses: actions/upload-artifact@v3
3939
with:
4040
name: Code coverage (MacOS)
4141
path: "**/coverage.cobertura.xml"
@@ -64,12 +64,12 @@ jobs:
6464
attempt_limit: 2
6565
- name: Upload test results (Ubuntu)
6666
if: ${{ always() }}
67-
uses: actions/upload-artifact@v4
67+
uses: actions/upload-artifact@v3
6868
with:
6969
name: Test results (Ubuntu)
7070
path: TestResults
7171
- name: Upload coverage
72-
uses: actions/upload-artifact@v4
72+
uses: actions/upload-artifact@v3
7373
with:
7474
name: Code coverage (Ubuntu)
7575
path: "**/coverage.cobertura.xml"
@@ -98,12 +98,12 @@ jobs:
9898
attempt_limit: 2
9999
- name: Upload test results (Windows)
100100
if: ${{ always() }}
101-
uses: actions/upload-artifact@v4
101+
uses: actions/upload-artifact@v3
102102
with:
103103
name: Test results (Windows)
104104
path: TestResults
105105
- name: Upload coverage
106-
uses: actions/upload-artifact@v4
106+
uses: actions/upload-artifact@v3
107107
with:
108108
name: Code coverage (Windows)
109109
path: "**/coverage.cobertura.xml"
@@ -128,7 +128,7 @@ jobs:
128128
run: vstest.console.exe .\Build\Tests\Testably.Abstractions.Tests\net48\Testably.Abstractions.Tests.dll .\Build\Tests\Testably.Abstractions.Parity.Tests\net48\Testably.Abstractions.Parity.Tests.dll .\Build\Tests\Testably.Abstractions.Testing.Tests\net48\Testably.Abstractions.Testing.Tests.dll /Logger:trx /ResultsDirectory:TestResults
129129
- name: Upload test results (.NET Framework)
130130
if: ${{ always() }}
131-
uses: actions/upload-artifact@v4
131+
uses: actions/upload-artifact@v3
132132
with:
133133
name: Test results (.NET Framework)
134134
path: TestResults
@@ -146,7 +146,7 @@ jobs:
146146
run: echo ${{ github.event.number }} > PR_NUMBER.txt
147147
- name: Archive PR number
148148
if: github.event_name == 'pull_request'
149-
uses: actions/upload-artifact@v4
149+
uses: actions/upload-artifact@v3
150150
with:
151151
name: PR_NUMBER
152152
path: PR_NUMBER.txt

‎.github/workflows/test-report.yml‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
name: 'Test Report'
2+
on:
3+
workflow_run:
4+
workflows: ['CI']
5+
types:
6+
- completed
7+
jobs:
8+
report:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: dorny/test-reporter@v1
12+
if: success() || failure()
13+
with:
14+
artifact: Test results (MacOS)
15+
name: MacOS Tests
16+
path: '*.trx'
17+
reporter: dotnet-trx
18+
fail-on-error: 'false'
19+
- uses: dorny/test-reporter@v1
20+
if: success() || failure()
21+
with:
22+
artifact: Test results (Ubuntu)
23+
name: Ubuntu Tests
24+
path: '*.trx'
25+
reporter: dotnet-trx
26+
fail-on-error: 'false'
27+
- uses: dorny/test-reporter@v1
28+
if: success() || failure()
29+
with:
30+
artifact: Test results (Windows)
31+
name: Windows Tests
32+
path: '*.trx'
33+
reporter: dotnet-trx
34+
fail-on-error: 'false'
35+
- uses: dorny/test-reporter@v1
36+
if: success() || failure()
37+
with:
38+
artifact: Test results (.NET Framework)
39+
name: .NET Framework Tests
40+
path: '*.trx'
41+
reporter: dotnet-trx
42+
fail-on-error: 'false'

‎Testably.Abstractions.sln‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "_", "_", "{94F99274-3518-45
1616
LICENSE = LICENSE
1717
nuget.config = nuget.config
1818
README.md = README.md
19+
renovate.json = renovate.json
1920
EndProjectSection
2021
EndProject
2122
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{61F335A6-9CE0-4040-A34F-E70B1A55077D}"
@@ -43,6 +44,7 @@ EndProject
4344
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github", ".github", "{5E35E265-7110-47A0-9E3E-B5180BBB5AA6}"
4445
ProjectSection(SolutionItems) = preProject
4546
coverage-settings.xml = coverage-settings.xml
47+
.github\mergify.yml = .github\mergify.yml
4648
EndProjectSection
4749
EndProject
4850
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "stryker", "stryker", "{4D8D7391-1E7B-4051-AD7E-4086AFD4E024}"
@@ -61,6 +63,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{
6163
.github\workflows\pr.yml = .github\workflows\pr.yml
6264
.github\workflows\release.yml = .github\workflows\release.yml
6365
.github\workflows\stryker.yml = .github\workflows\stryker.yml
66+
.github\workflows\test-report.yml = .github\workflows\test-report.yml
6467
EndProjectSection
6568
EndProject
6669
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Testably.Abstractions.Parity.Tests", "Tests\Testably.Abstractions.Parity.Tests\Testably.Abstractions.Parity.Tests.csproj", "{E9A42D82-0609-4D6B-B270-A30176B4FCF2}"

‎renovate.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"packageRules": [
77
{
88
"matchPackagePatterns": "^Testably.Abstractions",
9-
"groupName": ["Testably.Abstractions packages"]
9+
"groupName": [ "Testably.Abstractions packages" ]
1010
}
11-
]
11+
],
12+
"ignoreDeps": [ "actions/download-artifact", "actions/upload-artifact" ]
1213
}

0 commit comments

Comments
 (0)