Skip to content

fix: 🐛 make types @types/react@18 compatible #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Andrey-Bazhanov
Copy link
Contributor

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa749a0:

Sandbox Source
tannerlinsley/react-query Configuration
tannerlinsley/react-query Configuration

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #3481 (fa749a0) into beta (aa723a0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             beta    #3481      +/-   ##
==========================================
- Coverage   96.94%   96.94%   -0.01%     
==========================================
  Files          46       46              
  Lines        2391     2390       -1     
  Branches      714      714              
==========================================
- Hits         2318     2317       -1     
  Misses         71       71              
  Partials        2        2              
Impacted Files Coverage Δ
src/reactjs/Hydrate.tsx 100.00% <100.00%> (ø)
src/reactjs/QueryErrorResetBoundary.tsx 100.00% <100.00%> (ø)
src/reactjs/tests/utils.tsx 97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa723a0...fa749a0. Read the comment docs.

@Andrey-Bazhanov
Copy link
Contributor Author

@TkDodo here we go again)

Any eta of v4 release?

@vercel
Copy link

vercel bot commented Apr 8, 2022

Deployment failed with the following error:

Creating the Deployment Timed Out.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 8, 2022

I wanted to achieve two things:

  1. get rid of React.FC and similar things altogether and just type the props accordingly.
  2. use react 18 typings locally. this has shown some other issues around typings that we might have with useQueries

I've created a PR to supersede this one:

@TkDodo TkDodo closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants