Skip to content

Conversation

soumyamahunt
Copy link
Contributor

No description provided.

@soumyamahunt soumyamahunt added enhancement New feature or request help wanted Extra attention is needed labels Jul 20, 2023
@Ariandr
Copy link

Ariandr commented Jan 11, 2024

Hi @soumyamahunt
Are there issues with Cocoapods integration?

@soumyamahunt
Copy link
Contributor Author

Hi @soumyamahunt
Are there issues with Cocoapods integration?

Hi @Ariandr, Cocoapods doesn't support macros unlike Swift package.

@Ariandr
Copy link

Ariandr commented Jan 12, 2024

@soumyamahunt
I see, it's a shame. Hopefully soon the support will be added so that you can add it to Cocoapods.

@soumyamahunt soumyamahunt changed the title feat: add CocoaPods support feat: added CocoaPods support Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ea6ff6) 94.33% compared to head (9f9b3c5) 94.33%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         100      100           
  Lines        3335     3336    +1     
=======================================
+ Hits         3146     3147    +1     
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soumyamahunt soumyamahunt merged commit 377a87e into main Jan 25, 2024
@soumyamahunt soumyamahunt deleted the cocoapods branch January 25, 2024 20:27
@Ariandr
Copy link

Ariandr commented Jan 26, 2024

Hi @soumyamahunt
Thank you for adding the CocoaPods support! 🥳
Was it hard to do?
Or did they add a workaround for this?

@soumyamahunt
Copy link
Contributor Author

Hi @soumyamahunt
Thank you for adding the CocoaPods support! 🥳
Was it hard to do?
Or did they add a workaround for this?

No workaround has been added by CocoaPods. I found a workaround using existing features which was quite hard to test, especially with CocoaPods taking around 1 hour to run linting.

I am writing a medium post on the workaround that other macro authors can use. Stay tuned.

@Ariandr
Copy link

Ariandr commented Jan 27, 2024

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants