This repository was archived by the owner on Jun 1, 2023. It is now read-only.
super minor tweak to README & warning emit in generate #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heckj
changed the title
generate
heckj
changed the title
generate
|
@heckj I'm so glad to hear that you finally figured that out, though I'm obviously not thrilled by how much time you had to spend chasing that down. I think the proposed changes to the documentation and code is absolutely spot-on, and will go a long way to helping others avoid having the same issue. |
mattt
reviewed
Apr 22, 2020
mattt
suggested changes
Apr 22, 2020
|
Oh, one more thing – please add lines to the Changelog under the section "Fixed" for the README change and under "Updated" for the logger message change. |
Co-Authored-By: Mattt <[email protected]>
MaxDesiatov
reviewed
Apr 23, 2020
MaxDesiatov
reviewed
Apr 23, 2020
Co-Authored-By: Max Desiatov <[email protected]>
Co-Authored-By: Max Desiatov <[email protected]>
|
@heckj Perfect. Thanks again for your help. This goes a long way to making @MaxDesiatov Gosh, how I love GitHub's "suggestions in PRs" feature. Thanks for jumping in on these! |
mattt
approved these changes
Apr 23, 2020
|
Thanks for the updates last night! I crashed hard. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this may be me just being an idiot, but I completely missed
sourcevs.sourcesin the README example for using the wiki code generation example, and burned hours hunting it down. For the example, I think it would be awesome if it matched up with the default so that others don't stub their toes on this particular nit.I also made a minor tweak (separate commit) to emit a warning so that at least some output appears when it fails to find any source files to generate against.
related to #86